Skip to content

/ teletype

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #127 by saturating values at int16 limits #128

Closed
wants to merge 3 commits into from
Closed

Fixes #127 by saturating values at int16 limits #128

wants to merge 3 commits into from

Conversation

@burnsauce
Copy link
Contributor

@burnsauce burnsauce commented Oct 27, 2017 •
edited

What does this PR do?

Saturates values entered into scripts at int16 limits.

How should this be manually tested?

> 123456
=> 32767
> -123456
=> -32768
> 123654978934995432468491
=> 32767

Any background context you want to provide?

Thought of this while investigating MUL saturation.

I have,

  • updated CHANGELOG.md
  • [na] updated the documentation
burnsauce added 3 commits Oct 23, 2017
@burnsauce
Fixes #120 by updating only dirty lines
Loading status checks…
a3e5d27 
Except in pattern / tracker mode, which would require a refactor.
@burnsauce
Fixes #119 by saturating multiplication.
Loading status checks…
ee216fa
@burnsauce
Fixes #127 by saturating values at int16 limits
Loading status checks…
db0ad95
@burnsauce burnsauce force-pushed the burnsauce:saturate_val branch from 07e4c5d to db0ad95 Oct 28, 2017
@burnsauce burnsauce closed this Oct 28, 2017
@burnsauce burnsauce deleted the burnsauce:saturate_val branch Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@burnsauce