Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require confirm for flash initialization #170

Merged
merged 1 commit into from Dec 2, 2018
Merged

require confirm for flash initialization #170

merged 1 commit into from Dec 2, 2018

Conversation

@tehn
Copy link
Member

@tehn tehn commented Dec 2, 2018

What does this PR do?

on flash_reset detection (checking magic number in flash_prepare) blink a light and wait for confirmation by pressing key down. otherwise it times out and doesn't run.

Provide links to any related discussion on lines.

How should this be manually tested?

works perfectly well for newly flashed units. we'd need to see the bug-state to trigger this, which isn't known. it's a protection measure at this point.

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • run make format on each commit
@tehn tehn requested a review from scanner-darkly Dec 2, 2018
@tehn
Copy link
Member Author

@tehn tehn commented Dec 2, 2018

note

this is a confusing mechanism, to protect flash.

if you're flashing "fresh" from git you must hit the button within the flashing-period, otherwise boot will fail (haven't had a minute to understand why)

if you're flashing from a hex file with presets the magic number will already be set and you won't be presented with the flashing-need-for-pressing-button

@tehn tehn merged commit 8772237 into master Dec 2, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tehn tehn deleted the flash_reset_confirm branch Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants