Skip to content

/ teletype

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for flash initialization #171

Merged
merged 1 commit into from Dec 3, 2018
Merged

fixes for flash initialization #171

merged 1 commit into from Dec 3, 2018

Conversation

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Dec 3, 2018

What does this PR do?

further fixes for flash initialization:

  • added a screen with a warning
  • previous change would always init with blank scenes
  • added a safeguard for preset_no

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • run make format on each commit
@scanner-darkly
fixes for flash initialization
Loading status checks…
1404706
@scanner-darkly scanner-darkly requested a review from tehn Dec 3, 2018
@scanner-darkly
Copy link
Member Author

@scanner-darkly scanner-darkly commented Dec 3, 2018

also fixed some formatting, when doing a compare use w=1 in the URL to ignore whitespace changes.
@tehn
tehn approved these changes Dec 3, 2018
View changes
@tehn tehn merged commit 1b53ffe into monome:master Dec 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@csboling csboling mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehn tehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@scanner-darkly @tehn