bugfix: git sha1 script requires bash #179
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What does this PR do?
Without specifying a shell, make will use
/bin/sh, which on some environments (Ubuntu, and therefore this Dockerfile) is notbash. This causes redirection to fail in the bit that generates the git sha1 to embed in the firmware. Alsogit describe --always --dirtywas winding up with two different version numbers in the string displayed on Teletype, like3.0.0 v2.2.0-alpha.7-244as well as the wrong tag for some reason, this change adds--exclude '*'to omit tags in this part so you just get a version + sha like3.0.0 0F3DAA7-DIRTY.Provide links to any related discussion on lines.
This was causing some confusion because the version number was coming out weird from my builds: 1, 2
How should this be manually tested?
Build ye Firm-Ware, flafhe ye Module.
I have,
CHANGELOG.md(N/A)make formaton each commit (N/A)