Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix $.POL change that broke inputs w/ DEVICE.FLIP #182

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@csboling
Copy link
Collaborator

@csboling csboling commented Jul 12, 2019

What does this PR do?

Fixes #181 - changes for $.POL broke input processing when DEVICE.FLIPped

Provide links to any related discussion on lines.

https://llllllll.co/t/teletype-3-feature-requests-and-discussion/16219/364

How should this be manually tested?

DEVICE.FLIP and check each trigger input.

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

#181

I have,

  • updated CHANGELOG.md - wasn't sure if this should be marked a FIX as this is a pretty major breakage but DEVICE.FLIP was introduced in 3.1.0
  • updated the documentation (N/A)
  • run make format on each commit
@tehn tehn merged commit 8756025 into monome:master Jul 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants