edit mode: dim M when metro inactive, fix out of bounds array access #191
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What does this PR do?
When
M.ACTis 0, dim theMin the line editor prompt on the metro script, to match muted scripts. Also fix an out-of-bounds array access that I don't think was causing any trouble but could make this feature behave incorrectly when new members are added toscene_variables_tin the future.Provide links to any related discussion on lines.
https://llllllll.co/t/teletype-3-feature-requests-and-discussion/16219/408?u=csboling
How should this be manually tested?
While editing the metro script, use CTRL+F9 to toggle the metro on and off, and see the
Mdim to match the brightness of muted scripts. The same behavior is seen when runningM.ACT FLIPmanually.Any background context you want to provide?
If the related Github issues aren't referenced in your commits, please link to them here.
I have,
CHANGELOG.mdmake formaton each commit