Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern mode key bindings #194

Merged
merged 15 commits into from Apr 9, 2020
Merged

Conversation

@discohead
Copy link
Contributor

@discohead discohead commented Mar 23, 2020

What does this PR do?

Adds the following keybindings to pattern/tracker mode:

ALT-[ ]|SEMITONE UP, DOWN
CTRL-[ ]|FIFTH UP, DOWN
SH-[ ]|OCTAVE UP, DOWN
ALT-<0-9>|NUM SEMITONES UP
// 0 = 10 and 1 = 11
SH-ALT-<0-9>|NUM SEMITONES DOWN
// 0 = 10 and 1 = 11

Demo video: https://www.youtube.com/watch?v=gxOZY_MgsvE

Provide links to any related discussion on lines.

https://llllllll.co/t/teletype-firmware-discussion/13961/41

How should this be manually tested?

  1. Enter Pattern/Tracker Mode
  2. Try key commands listed above
  3. Verify values entered match values in N table

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • run make format on each commit

NOTE: make format formatted a bunch of lines in help_mode.c that were not in my original changeset

discohead added 9 commits Mar 22, 2020
@tehn
tehn approved these changes Apr 7, 2020
@tehn
Copy link
Member

@tehn tehn commented Apr 7, 2020

@scanner-darkly @csboling

whoa. there hasn't been an official TT version bump since last july. time for 3.2.0?

@discohead
Copy link
Contributor Author

@discohead discohead commented Apr 7, 2020

@tehn I've made a couple of cool new ops as well. I'll make a PR for those tonight so you can take a look to see if you want to include them.

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Apr 7, 2020

will take a look at all the PRs tonight!

module/pattern_mode.c Outdated Show resolved Hide resolved
discohead added 6 commits Apr 8, 2020
@tehn tehn merged commit 91bf505 into monome:master Apr 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants