Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FADER.SCALE, FADER.CAL.MIN/MAX, FADER.CAL.RESET #198

Merged
merged 6 commits into from Apr 18, 2020
Merged

Conversation

@discohead
Copy link
Contributor

@discohead discohead commented Apr 13, 2020

What does this PR do?

Adds scaling for FADER and FB just like there is for IN and PARAM

Admittedly feels a bit naughty putting ii device related functionality along side the onboard hardware stuff in main.c and src/state, but I wasn't sure what might be a better approach. Open to suggestions.

Provide links to any related discussion on lines.

How should this be manually tested?

A 16n is required. I have the Sweet Sixteen, so someone with the original should test it.

The scaling and calibration behavior should be exactly the same as it is for IN and PARAM.

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • run make format on each commit
@tehn
Copy link
Member

@tehn tehn commented Apr 13, 2020

i don't have a 16n, so any additional testing would be great.

getting ready to the next TT version release, so this could be added

@discohead
Copy link
Contributor Author

@discohead discohead commented Apr 13, 2020

@tehn it works perfectly with the Sweet Sixteen. I don't have access to an original 16n, it should work fine though. maybe @scanner-darkly ?

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Apr 13, 2020

i'll give it a test tonight or tomorrow!

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Apr 16, 2020

sorry, it's been a hectic couple of days, will get to it this afternoon!

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Apr 17, 2020

sorry - looks like i won't be able to test. my 16n currently has the leader firmware, and i'm having difficulty updating the firmware.

in any case, i don't think testing on a different 16n is really necessary - the code isn't doing anything that would be hardware specific, it just reads values the same way FADER op does.

@tehn
tehn approved these changes Apr 18, 2020
@tehn tehn merged commit 93eaa26 into monome:master Apr 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants