Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize fb min max values #200

Merged
merged 1 commit into from Apr 29, 2020
Merged

Conversation

@discohead
Copy link
Contributor

@discohead discohead commented Apr 29, 2020

What does this PR do?

initialize min and max values for the FADER op so that they aren't garbage prior to first calibration

Provide links to any related discussion on lines.

https://llllllll.co/t/teletype-3-2-0-release/31530/32?u=discohead

How should this be manually tested?

need TT with clean flash and a Faderbank, before calibrating the FADER op the values should at least be sensible

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • run make format on each commit
@tehn tehn merged commit 61ba839 into monome:master Apr 29, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants