fix for X and B not working for negative values, formatting #226
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What does this PR do?
X...andB...number formats not producing correct values for numbers 0x8000 and higher.Provide links to any related discussion on lines.
https://llllllll.co/t/teletype-3-2-feature-requests-and-discussions/32052/194
How should this be manually tested?
try inputting hex numbers in the range of 0x8000 or higher
try inputting binary numbers in the range 0b1000000000000000 or higher
I have,
CHANGELOG.mdmake formaton each commit