.editorconfig & .clang-format

[samdoshi]

I've added a .editorconfig(website) and a .clang-format (website) to the src directory.

I've re-formatted config.mk by hand.

I've added a new make target format (it's not the best bit of Makefile magic you'll ever see...), and run it to reformat the teletype source code.

If you don't particularly like any of the choices I've made it .editorconfig or .clang-format, let me know and I can rerun.

[pq]

This looks odd to me. Maybe a matter of setting ReflowComments to false?

[samdoshi]

It's possible that this just comment block just needs deleting. @tehn?

[tehn]

yes let's throw it away

[pq]

Can clang insert a newline at EOF or is that an editor config thing?

[pq]

Ah, wait, I see it in .editorconfig. Maybe this file just needs to be reprocessed.

[samdoshi]

.editorconfig only applies on editor save. Not when clang-format runs. I'll edit it and force push.

[pq]

What about something like

clang-format -style=file -i *.c *.h
clang-format -style=file -i euclidean/*.c euclidean/*.h

Annoying that **/*.c doesn't work.

EDIT: better still?:

find . -name '*.c' -o -name '*.h' | xargs clang-format -style=file -i

[samdoshi]

Problem is we don't necessarily want to format all the files. e.g. euclidean/data.* is auto generated by euclidean.hs. Not that it really matters that much...

[pq]

Aha!

Well, you're right that it probably doesn't matter... But if it does maybe add a no format comment to the header of the file?

[samdoshi]

It's a good idea. At some point (hopefully in the not too distant future) I'd like to split the code up into smaller files, so some sort of globing will be necessary. I'll probably modify the Haskell code to generate the files as you suggest.

[pq]

Hadn't noticed that you're generating from Haskell. Neat!

Another consideration would be to add codegen to the build process and then not commit the generated C sources. Of course, that requires all devs have haskell installed... (Maybe that's a show-stopper.)

But anyway, cool!