Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve line editor movement. Add "delete to end of word" command. #259

Merged
merged 1 commit into from
May 31, 2021
Merged

Improve line editor movement. Add "delete to end of word" command. #259

merged 1 commit into from
May 31, 2021

Conversation

svi-n
Copy link
Contributor

@svi-n svi-n commented May 31, 2021

What does this PR do?

  • Adds "delete to end of word" command for line editing. Bound to alt-d.
  • Adds additional keybinds for move forwards/backwards by word (alt-f and alt-b).
  • Updates "move forward/backwards by word" commands to skip all intervening space between the cursor and the word e.g. in the line "A_ _ _B" with the cursor at B, moving backwards by word will place the cursor at A instead of moving one space back per key press.

Provide links to any related discussion on lines.

Discussion here.

How should this be manually tested?

  • Type text in live or edit mode. Use alt-f, alt-b, alt-d keybinds.

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md
  • updated the documentation
  • updated help_mode.c (if applicable)
  • run make format on each commit
  • run tests

@tehn tehn merged commit cd2ae5a into monome:main May 31, 2021
@scanner-darkly
Copy link
Member

@svi-n - sorry, forgot to mention - could you also update help_mode.c?

@svi-n
Copy link
Contributor Author

svi-n commented Jun 1, 2021

Ack - I'll send a change to update it.

@scanner-darkly
Copy link
Member

@svi-n we're getting close to a release, do you think you'll be able to update help_mode.c?

@svi-n
Copy link
Contributor Author

svi-n commented Jun 17, 2021

#267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants