Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #32

Merged
merged 5 commits into from Apr 7, 2016
Merged

Unit tests #32

merged 5 commits into from Apr 7, 2016

Conversation

@samdoshi
Copy link
Collaborator

@samdoshi samdoshi commented Apr 7, 2016

Adds unit tests using the greatest library.

Moves the simulator up a directory

Also commit 7c66926 changes the prototype for parse so as to remove the global temp variable.

@tehn tehn merged commit ce041c0 into monome:master Apr 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pq
Copy link
Contributor

@pq pq commented Apr 7, 2016

Awesome.

So nice too that you added a make test target. Behold:

screen shot 2016-04-07 at 9 12 19 am

Moving forward, having automated tests to vet PRs should be a real boon.

Cheers!

@@ -1,4 +1,4 @@
language: generic
language: c

This comment has been minimized.

@pq

pq Apr 7, 2016
Contributor

Yay!

Do we want to specify compiler? (Or have a matrix?)

For example:

compiler:
  - clang
  - gcc

(From: https://docs.travis-ci.com/user/languages/c)

This comment has been minimized.

@samdoshi

samdoshi Apr 7, 2016
Author Collaborator

I made it generic initially as we bring our own toolchain!

Multiple compilers seems a bit overkill to me, for now the only target that matters is the hardware (really we should install gcc-4.4, but baby steps...).

This comment has been minimized.

@pq

pq Apr 7, 2016
Contributor

Sounds good. If gcc is the expectation may not hurt to specify it but no biggie either way!


MaxEmptyLinesToKeep: 2
---

This comment has been minimized.

@pq

pq Apr 7, 2016
Contributor

Is there a reason not to put these at the root dir? IOW do we not want to format the other bits too?

This comment has been minimized.

@samdoshi

samdoshi Apr 7, 2016
Author Collaborator

Basically, yes, there is the libavr32 submodule which is used by other modules.

I'm just being cautious, if everyone gets on with using an editorconfig and clang-format then we'll do libavr32 as well, and then move these files to the root.

This comment has been minimized.

@pq

pq Apr 7, 2016
Contributor

Oh, right. Cool. Thanks for the clarification!

[*.{h,hpp,c,cpp}]
indent_style = space
indent_size = 4
trim_trailing_whitespace = true

This comment has been minimized.

@pq

pq Apr 7, 2016
Contributor

Same question here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants