protect tele_ii_tx from interrupts #60
Closed
Conversation
|
....after examining the code more i don't think some of the above changes have any real effect so beyond the protection against an infinite loop and the volatile change the rest is not needed (since the normal event queue provides most of the needed safety). i'm going to restructure this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
note: this change is untested and intended primarily for review.
no idea (yet) if this helps with stability/lockups but while working through the ii code to understand how it all works i noticed that the queue manipulation in
tele_ii_tx()isn't protected from changes made to the queue (at interrupt level) inhandler_IItx().this change:
waitingflag handling to reduce potential for partially filled ii queue entries being marked as sendable or marked as available before being sent.tele_ii_tx()).