Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdf issues #77

Merged
merged 1 commit into from Jul 20, 2017
Merged

Fix pdf issues #77

merged 1 commit into from Jul 20, 2017

Conversation

@samdoshi
Copy link
Collaborator

@samdoshi samdoshi commented Jul 20, 2017

Continuing from PR #76...

Fixes the fonts issue and fixes the Latex errors.

Font errors were due to using the wrong file for latex_preamble as well as it missing a / (hat tip to @jmsole).

Latex errors were caused by not forcing a blank line after latex_preamble, I've modified the Python code to always do that.

@jlmitch5 I've based my changes on top of your fork and squashed it down to a single commit to maintain your authorship too.

I'll merge in about 24 hours to given anyone interested a chance to test.

use the correct template for latex_preamble
correct jinga to jinja
force new lines after the latex_preamble to stop errors
@jmsole
Copy link

@jmsole jmsole commented Jul 20, 2017

All working well for me. Thanks @samdoshi!

@jlmitch5
Copy link
Contributor

@jlmitch5 jlmitch5 commented Jul 20, 2017

thanks! Code looks good, and I pulled down and everything works great now!

@samdoshi samdoshi merged commit 4a2c2c1 into monome:master Jul 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdoshi samdoshi deleted the samdoshi:pdf-fixes branch Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants