-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teletype Docs UX Enhancements #78
Conversation
@@ -66,8 +66,8 @@ In most cases, the clipboard is shared between _live_, _edit_ and the 2 _preset_ | |||
|
|||
The pattern mode clipboard is independent of text and code clipboard. | |||
|
|||
| Key | Action | | |||
|---------------------|---------------------------------------------------------------------------------------| | |||
| Key | Action | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to make this change to the column headers?
@@ -4,8 +4,8 @@ make sure that the description column is long! | |||
Pandoc uses the size of the header column to calculate the absolute column widths | |||
(as Latex requires explict column sizes) | |||
--> | |||
| OP | OP _(set)_ | _(aliases)_ | Description | | |||
|------------------------|--------------|-------------|----------------------------------| | |||
| OP | OP _(set)_ | _(aliases)_ | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, did you intend to change the column headers?
@tehn @samdoshi I'm now comfortable merging this, if y'all could give a quick review. Happy to squash commits if you'd like me to (I think they're fairly semantic, but this is also a fairly small PR so they could be squashed to a single one too...y'alls call). I did rebuild the pdf with the table changes and they seem good: |
Not ready for merge!
This PR makes some UX enhancements to the pandoc generated HTML5 Teletype docs.
Things fixed in this PR:
target=“_blank”
on links off of docsThings I didn't get to.