Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teletype Docs UX Enhancements #78

Merged
merged 9 commits into from
Sep 13, 2017
Merged

Conversation

jlmitch5
Copy link
Contributor

@jlmitch5 jlmitch5 commented Jul 21, 2017

Not ready for merge!

This PR makes some UX enhancements to the pandoc generated HTML5 Teletype docs.

Things fixed in this PR:

  • stick TOC on left hand side of window
    • for mobile, hide behind hamburger icon
  • better responsiveness of wide tables (see Variables table in OPs and MODs section
    • currently, wide tables overflow the horizontal width of smaller screens.
    • I’ve updated things to fill better across screen sizes. The tables are still not great, but they are usable.
  • target=“_blank” on links off of docs
    • In past projects I’ve worked on, we’ve decided that links outside of the content you are currently looking at should open in a new tab so as to prevent context switching.
  • anchor link next to doc sections (allowing for linking of specific sections of the docs)
    • this shouldn’t be difficult because it’s already reflected in the URL as a hash
  • Update .editorconfig
  • Update h1 and h3-in-code-element css weirdness that got added

Things I didn't get to.

  • Quantization scale content is repeated
    • It’s fine that it’s repeated visually, need to see if the content is repeated in the repo…could lead to change drift
  • Include footnote sources under relevant sections (rather than at the bottom of the docs)
    • Not a big deal…if this isn’t a 5-minute fix, I’ll probably push this one out.
  • Explore the ability to export each section to it’s own .HTML file (not sure if that’s possible).
  • Enhancements to TOC
    • make full width (and click-link-to-close) for more narrow browser widths
    • highlight when hovering over a particular nav element in the TOC.

@@ -66,8 +66,8 @@ In most cases, the clipboard is shared between _live_, _edit_ and the 2 _preset_

The pattern mode clipboard is independent of text and code clipboard.

| Key | Action |
|---------------------|---------------------------------------------------------------------------------------|
| Key | Action |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to make this change to the column headers?

@@ -4,8 +4,8 @@ make sure that the description column is long!
Pandoc uses the size of the header column to calculate the absolute column widths
(as Latex requires explict column sizes)
-->
| OP | OP _(set)_ | _(aliases)_ | Description |
|------------------------|--------------|-------------|----------------------------------|
| OP | OP _(set)_ | _(aliases)_ | Description |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, did you intend to change the column headers?

@jlmitch5 jlmitch5 changed the title Not ready for merge: Teletype Docs UX Enhancements Teletype Docs UX Enhancements Sep 13, 2017
@jlmitch5
Copy link
Contributor Author

@tehn @samdoshi I'm now comfortable merging this, if y'all could give a quick review.

Happy to squash commits if you'd like me to (I think they're fairly semantic, but this is also a fairly small PR so they could be squashed to a single one too...y'alls call).

I did rebuild the pdf with the table changes and they seem good:

screen shot 2017-09-12 at 9 09 05 pm

screen shot 2017-09-12 at 9 09 26 pm

@tehn tehn merged commit 6c6cd33 into monome:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants