Teletype Docs UX Enhancements #78
Merged
Conversation
| @@ -66,8 +66,8 @@ In most cases, the clipboard is shared between _live_, _edit_ and the 2 _preset_ | |||
|
|
|||
| The pattern mode clipboard is independent of text and code clipboard. | |||
|
|
|||
| | Key | Action | | |||
| |---------------------|---------------------------------------------------------------------------------------| | |||
| | Key | Action | | |||
samdoshi
Jul 26, 2017
Collaborator
Did you mean to make this change to the column headers?
Did you mean to make this change to the column headers?
| @@ -4,8 +4,8 @@ make sure that the description column is long! | |||
| Pandoc uses the size of the header column to calculate the absolute column widths | |||
| (as Latex requires explict column sizes) | |||
| --> | |||
| | OP | OP _(set)_ | _(aliases)_ | Description | | |||
| |------------------------|--------------|-------------|----------------------------------| | |||
| | OP | OP _(set)_ | _(aliases)_ | Description | | |||
samdoshi
Jul 26, 2017
Collaborator
As above, did you intend to change the column headers?
As above, did you intend to change the column headers?
|
@tehn @samdoshi I'm now comfortable merging this, if y'all could give a quick review. Happy to squash commits if you'd like me to (I think they're fairly semantic, but this is also a fairly small PR so they could be squashed to a single one too...y'alls call). I did rebuild the pdf with the table changes and they seem good: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


Not ready for merge!
This PR makes some UX enhancements to the pandoc generated HTML5 Teletype docs.
Things fixed in this PR:
target=“_blank”on links off of docsThings I didn't get to.