Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all scripts in this repo are self-contained #21

Open
simonvanderveldt opened this issue Apr 30, 2019 · 2 comments
Open

Not all scripts in this repo are self-contained #21

simonvanderveldt opened this issue Apr 30, 2019 · 2 comments
Assignees

Comments

@simonvanderveldt
Copy link
Member

@simonvanderveldt simonvanderveldt commented Apr 30, 2019

I noticed some scripts in this repo have external dependencies.
For example the scales demo as well as several of the studies have a dependency on Polyperc, see
https://github.com/monome/we/blob/master/demos/scales.lua#L39

I was wondering how we want to handle this?
IMHO it would be better if the examples in this repo have no external dependencies.

@okyeron
Copy link

@okyeron okyeron commented Jun 23, 2019

Troubleshooting a norns user on lines today and came up with this problem. demos/scales.lua needs Polyperc and this user did not have awake installed for some reason.

Update the example to use PolySub instead?

@tehn
Copy link
Member

@tehn tehn commented Jun 23, 2019

polysub is going to eventually also moved out of we

better fix is to just note the requirement in the comment text for now. we need to have more robust error messages for missing engines.

as a general note: not all scripts/repos are going to be self-contained, and will very commonly require engines from another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants