Add two pingpong sequence modes for whitewhale. #4
Conversation
| w.wp[pattern].step_mode = mForward; | ||
| else if(x == LENGTH-1) | ||
| } |
genericwoods
Oct 25, 2016
Minor: it looks like the alignment of these closing braces is kind of off.
Minor: it looks like the alignment of these closing braces is kind of off.
GoneCaving
Oct 25, 2016
Author
Contributor
Really? Looks ok here.
Really? Looks ok here.
genericwoods
Oct 25, 2016
Just to make sure we’re seeing the same thing:
Also appears to be off on lines 310-343
Just to make sure we’re seeing the same thing:
Also appears to be off on lines 310-343
| w.wp[pattern].step_mode = mPing; | ||
| w.wp[pattern].ping_dir = mPingFwd; | ||
| } | ||
| else if(x == LENGTH-5) { |
genericwoods
Oct 25, 2016
I mentioned this in our DM convo, but I think we can clean up some of the existing logic here (that’s made more confusing with each playback mode added) by using if(x == LENGTH-mPingRep) here (we may need to explicitly assign numerical values to each of the enums, forgive me that I’m a bit rusty on vanilla C programming)
I mentioned this in our DM convo, but I think we can clean up some of the existing logic here (that’s made more confusing with each playback mode added) by using if(x == LENGTH-mPingRep) here (we may need to explicitly assign numerical values to each of the enums, forgive me that I’m a bit rusty on vanilla C programming)
GoneCaving
Oct 25, 2016
Author
Contributor
The enums are 0 up, so should be easy enough. If we don't mind the overhead of setting the mPingFwd regardless of mode, we might be able to combine all of the modes into a single block (LENGTH-x).
The enums are 0 up, so should be easy enough. If we don't mind the overhead of setting the mPingFwd regardless of mode, we might be able to combine all of the modes into a single block (LENGTH-x).
genericwoods
Oct 25, 2016
Even better, that seems like a good idea to me
Even better, that seems like a good idea to me
|
To capture my response on the Lines forum, I think dropping the repeating mode makes the most sense (retains consistency with the larger grid, and keeps the code simpler) |
|
OK, abandoning this, and will adopt the comments above (and hopefully address the tabs vs spaces issue). |
Per this thread:
http://llllllll.co/t/white-whale-ping-pong-playback-mode/4816/41
mPing: 1,2,3,4,3,2,1,2...
mPingRep: 1,2,3,4,4,3,2,1,1,...
Seems to be working, pattern & series mode checked. I've not tested on a smaller grid, and i think there may be a clash with the keys from the left hand side? Happy to make any further changes to address this? (drop one mode?). It would help to know what the "FIXME" around line 882 relate to.