Skip to content

Conversation

@monosoul
Copy link
Owner

@monosoul monosoul commented Nov 5, 2025

This change removes getting skipped files popup.

Note on implementation: given that I don't use that plugin myself atm and don't want to spend too much time working on it, this change is 99% AI generated. I did check the implementation tho and it seems to be sane.

Fixes #67

@monosoul monosoul requested a review from Copilot November 5, 2025 15:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "Getting Skipped Files" popup by replacing the synchronous, UI-blocking Task implementation with a cache-based approach that loads skipped worktree files asynchronously in the background.

Key changes:

  • Introduced SkippedWorktreeFilesCache to manage async loading and caching of skipped worktree files
  • Converted GetSkippedWorktreeFilesTask from a UI-blocking Task to a standalone suspend function
  • Modified the changes view modifier to use cached data instead of triggering a blocking popup

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
SkippedWorktreeFilesCache.kt New service that handles async loading and caching of skipped worktree files
SkippedWorktreeChangesViewModifier.kt Updated to use cache instead of ProgressManager task
GetSkippedWorktreeFilesTask.kt Converted from Task class to standalone suspend function
ExtendedUpdateIndexTask.kt Added cache clearing and view refresh after index updates
plugin.xml Registered the new cache service
SkippedWorktreeFilesCacheTest.kt New test file for cache functionality
SkippedWorktreeChangesViewModifierTest.kt Updated tests to work with cache-based approach
GetSkippedWorktreeFilesTaskTest.kt Updated tests for new suspend function
ExtendedUpdateIndexTaskTest.kt Added verification of cache clearing behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 33 to 35
if (!isLoading) {
isLoading = true
scope.launch {
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Race condition: Multiple concurrent calls to getOrLoad() could pass the !isLoading check before isLoading is set to true, potentially launching multiple coroutines. Use an atomic boolean or synchronization mechanism to ensure thread-safe state transitions.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.90%. Comparing base (d434f0f) to head (744e4f1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...extended/changes/view/SkippedWorktreeFilesCache.kt 85.00% 3 Missing ⚠️
...x/extended/changes/view/GetSkippedWorktreeFiles.kt 93.33% 0 Missing and 1 partial ⚠️
...changes/view/SkippedWorktreeChangesViewModifier.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   92.85%   90.90%   -1.95%     
==========================================
  Files          10       11       +1     
  Lines         112      132      +20     
  Branches       15       17       +2     
==========================================
+ Hits          104      120      +16     
- Misses          3        6       +3     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@monosoul monosoul requested a review from Copilot November 5, 2025 17:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@monosoul monosoul merged commit db5b038 into master Nov 5, 2025
2 of 4 checks passed
@monosoul monosoul deleted the fix/67/skipped-files-popup branch November 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not show "Getting Skipped Files" popup

1 participant