Object.defineBinding deprecation notice doesn't give instructions #1120

Closed
Stuk opened this Issue Feb 12, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@Stuk
Contributor

Stuk commented Feb 12, 2013

Object.defineBinding deprecated.  See the comment below this warning for migration instructions.

followed by an error and no instructions :(

@kriskowal

This comment has been minimized.

Show comment Hide comment
@kriskowal

kriskowal Feb 12, 2013

Member

It’s in the source…but seems that did not work.

Member

kriskowal commented Feb 12, 2013

It’s in the source…but seems that did not work.

@Stuk

This comment has been minimized.

Show comment Hide comment
@Stuk

Stuk Feb 12, 2013

Contributor

Oh I see, the instructions are in a comment in the code!

I think it would be better to put the instructions in the warning, or put a link to a page containing the instructions (wiki page?)

Contributor

Stuk commented Feb 12, 2013

Oh I see, the instructions are in a comment in the code!

I think it would be better to put the instructions in the warning, or put a link to a page containing the instructions (wiki page?)

@kriskowal

This comment has been minimized.

Show comment Hide comment
@kriskowal

kriskowal Feb 12, 2013

Member

On Tue, Feb 12, 2013 at 2:20 PM, Stuart Knightley
notifications@github.comwrote:

Oh I see, the instructions are in a comment in the code!

I think it would be better to put the instructions in the warning, or put a
link to a page containing the instructions (wiki page?)

For sure.

Member

kriskowal commented Feb 12, 2013

On Tue, Feb 12, 2013 at 2:20 PM, Stuart Knightley
notifications@github.comwrote:

Oh I see, the instructions are in a comment in the code!

I think it would be better to put the instructions in the warning, or put a
link to a page containing the instructions (wiki page?)

For sure.

@Stuk Stuk assigned Stuk and unassigned kriskowal Jul 3, 2014

rayshan added a commit to rayshan/montage that referenced this issue Mar 2, 2015

replace deprecated "montage/core/bindings".Bindings
with "montage/core/bindings".Bindings

closes #1120

@hthetiot hthetiot added this to the v17.0.0 milestone Apr 12, 2017

@hthetiot hthetiot self-assigned this Apr 12, 2017

@hthetiot hthetiot closed this May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment