Skip to content

Repetition should not insert comments in the markup for it's internal bookkeeping #1151

Closed
marchant opened this Issue Mar 4, 2013 · 4 comments

4 participants

@marchant
MontageJS member
marchant commented Mar 4, 2013

No description provided.

@kriskowal kriskowal was assigned Mar 4, 2013
@aadsm
MontageJS member
aadsm commented Mar 4, 2013

Why?

@marchant
MontageJS member
marchant commented Mar 4, 2013

Because it's unnecessary and ugly

@kriskowal
MontageJS member

I will look into this after integrate-bindings is on master. I’ll look into alternatives like DOMRange and using the first child of each iteration as the boundary. My suspicion is that using boundary comments is more robust given that iterations may add and remove nodes between when the iteration is injected and retracted from the document.

@marchant
MontageJS member
marchant commented Mar 4, 2013

sounds good, let's see

@kriskowal kriskowal added a commit that referenced this issue Mar 5, 2013
@kriskowal kriskowal Use empty text nodes for iteration boundaries
Instead of empty comment nodes, per #1151.
4235354
@kstarink kstarink closed this Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.