not finding an object with a given label uses a rejected promise elsewhere when reviving declaration #1158

Closed
mczepiel opened this Issue Mar 10, 2013 · 7 comments

Projects

None yet

3 participants

@mczepiel
Member

For example

foo: {
    prototype: "foo",
    properties: {
        "aValue": "ok"
    }
}

},

bar: {
    prototype: "bar",
    bindings: {
        "someValue": {"<-": "@goo.otherValue"}
}

The typo goo should have been foo which would have found the value, instead we end up with an exception in trying to make the otherValue property of a rejected promise observable.

It should fail earlier.

@aadsm aadsm added a commit that referenced this issue Mar 11, 2013
@aadsm @aadsm aadsm + aadsm Stop UnitSerializer.getObjectByLabel returning a promise
getObjectByLabel was returning a rejected promise when the object was not found.
Related to gh-1158
515d609
Member
aadsm commented Mar 11, 2013

I believe @kriskowal needs to do the rest now

Member

What’s “the rest”, @aadsm?

@kriskowal kriskowal was assigned Mar 11, 2013
Member
aadsm commented Mar 11, 2013

Making sure that when getObjectByLabel returns undefined that an error is raised.

Member

@aadsm, right, in core/serialization/bindings. Thanks!

Member
aadsm commented Mar 11, 2013

It's not just there (actually I forgot that one :D), I can easily change it, but getObjectByLabel is also called in FRB.

@kriskowal kriskowal closed this Mar 11, 2013
@kriskowal kriskowal reopened this Mar 11, 2013
Member

@aadsm, do you know whether we’ve killed this issue?

@mczepiel mczepiel assigned aadsm and unassigned kriskowal May 28, 2014
Member
aadsm commented Jun 2, 2014

I believe we did

@aadsm aadsm closed this Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment