Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded dependencies, use npm #1539

Closed
2 of 6 tasks
rayshan opened this issue Feb 14, 2015 · 1 comment
Closed
2 of 6 tasks

Remove hardcoded dependencies, use npm #1539

rayshan opened this issue Feb 14, 2015 · 1 comment

Comments

@rayshan
Copy link
Contributor

rayshan commented Feb 14, 2015

  • date-converter.js

The original we're using is abandoned and hasn't been updated since 2007. Here's a maintained fork with many perf & bug fixes with smaller file size:
https://github.com/abritinthebay/datejs

Also should install via npm for dependency management then wrap as montage object.

Alternatively consider moments.js, not a drop-in replacement
http://momentjs.com

  • messageformat.js

https://github.com/SlexAxton/messageformat.js/

https://github.com/eligrey/classList.js
https://github.com/montagejs/montage/blob/master/core/dom.js#L92

@marchant
Copy link
Member

Sophiacom has used mommentjs for their montag calendar date picker, one more reason to consider it.

On Feb 14, 2015, at 13:15, Ray Shan notifications@github.com wrote:

The original we're using is abandoned and hasn't been updated since 2007. Here's a maintained fork with many perf & bug fixes with smaller file size:
https://github.com/abritinthebay/datejs

Also should install via npm for dependency management then wrap as montage object.

Alternatively consider moments.js, not a drop-in replacement
http://momentjs.com


Reply to this email directly or view it on GitHub.

@rayshan rayshan changed the title Update date-converter.js Update date-converter.js & messageformat.js Feb 15, 2015
@rayshan rayshan changed the title Update date-converter.js & messageformat.js Remove hardcoded dependencies, use npm Feb 19, 2015
@hthetiot hthetiot added this to the v17.0.x milestone Apr 13, 2017
@hthetiot hthetiot self-assigned this Apr 13, 2017
@hthetiot hthetiot closed this as completed May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants