Liquid flow 2 #1473
Merged
Liquid flow 2 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romancortes, who do you think should review this? |
|
This needs to be merged locally and tested against our demo apps |
Adds the ability to switch from Flow's by default virtual camera to the standard CSS 3D representation with a perspective parameter.
The computation was wrong when scene scale parameters weren't 1:1.
Adjust bounding box size based on the first iteration size and offset. It is backwards compatible, if the boundingBoxSize was set it will be respected.
|
@francoisfrisch I merged locally and I tested: Popcorn, Den-demo, Radioio, Rdd-demo/Flow, Flow-Test, Mjs-Wordpress-Flow-demo and Montage Studio. Everything was working right. I modified / saved / reloaded in Flow editor and everything right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds responsive/liquid properties to Flow and fixes several bugs.