Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Revert "[MDL-31708] - wiki 2.0 non-group member can see edit option i…

…n navigation block."

This reverts commit c583993.
  • Loading branch information...
commit 009d72139fc2d40b6501a9c7da6170e73d594684 1 parent 4782075
@stronk7 stronk7 authored
View
2  mod/wiki/lang/en/wiki.php
@@ -22,10 +22,8 @@
$string['backpage'] = 'Back to page';
$string['backtomapmenu'] = 'Back to map menu';
$string['changerate'] = 'Do you wish to change it?';
-$string['cannoteditpage'] = 'You can not edit this page.';
$string['cannotmanagefiles'] = 'You don\'t have permission to manage the wiki files.';
$string['cannotviewfiles'] = 'You don\'t have permission to view the wiki files.';
-$string['cannotviewpage'] = 'You can not view this page.';
$string['comparesel'] = 'Compare selected';
$string['comments'] = 'Comments';
$string['commentscount'] = 'Comments ({$a})';
View
2  mod/wiki/lib.php
@@ -535,7 +535,7 @@ function wiki_extend_navigation(navigation_node $navref, $course, $module, $cm)
$node = $navref->add(get_string('view', 'wiki'), $link, navigation_node::TYPE_SETTING);
}
- if (wiki_user_can_edit($subwiki)) {
+ if (has_capability('mod/wiki:editpage', $context)) {
$link = new moodle_url('/mod/wiki/edit.php', array('pageid' => $pageid));
$node = $navref->add(get_string('edit', 'wiki'), $link, navigation_node::TYPE_SETTING);
}
View
2  mod/wiki/locallib.php
@@ -764,7 +764,7 @@ function wiki_user_can_view($subwiki) {
// Each person owns a wiki.
if ($wiki->wikimode == 'collaborative' || $wiki->wikimode == 'individual') {
// Only members of subwiki group could view that wiki
- if (groups_is_member($subwiki->groupid)) {
+ if ($subwiki->groupid == groups_get_activity_group($cm)) {
// Only view capability needed
return has_capability('mod/wiki:viewpage', $context);
View
10 mod/wiki/pagelib.php
@@ -172,6 +172,10 @@ protected function setup_tabs($options = array()) {
if (!$manage and !($edit and groups_is_member($currentgroup))) {
unset($this->tabs['edit']);
}
+ } else {
+ if (!has_capability('mod/wiki:editpage', $PAGE->context)) {
+ unset($this->tabs['edit']);
+ }
}
@@ -320,7 +324,8 @@ function print_content() {
}
}
} else {
- echo get_string('cannotviewpage', 'wiki');
+ // @TODO: Tranlate it
+ echo "You can not view this page";
}
}
@@ -413,7 +418,8 @@ function print_content() {
if (wiki_user_can_edit($this->subwiki)) {
$this->print_edit();
} else {
- echo get_string('cannoteditpage', 'wiki');
+ // @TODO: Translate it
+ echo "You can not edit this page";
}
}
Please sign in to comment.
Something went wrong with that request. Please try again.