Permalink
Browse files

MDL-40436 block_course_list: Fix bad context resolution

We were trying to get the course context of a remote course
from a completely unrelated ID. It would sometimes work if the
ID was matching the one of a local course. In other places
we are not trying to find a context for the remote course, we
simply use the $PAGE context in format_string. So the usage
of the context has been removed here too.
  • Loading branch information...
1 parent 98f4a31 commit 0291a8b4922997493b0d90cc36ddefcdf05dd71f @FMCorz FMCorz committed Dec 12, 2013
Showing with 1 addition and 2 deletions.
  1. +1 −2 blocks/course_list/block_course_list.php
@@ -127,8 +127,7 @@ function get_remote_courses() {
$this->content->items[] = get_string('remotecourses','mnet');
$this->content->icons[] = '';
foreach ($courses as $course) {
- $coursecontext = context_course::instance($course->id);
- $this->content->items[]="<a title=\"" . format_string($course->shortname, true, array('context' => $coursecontext)) . "\" ".
+ $this->content->items[]="<a title=\"" . format_string($course->shortname, true) . "\" ".
"href=\"{$CFG->wwwroot}/auth/mnet/jump.php?hostid={$course->hostid}&amp;wantsurl=/course/view.php?id={$course->remoteid}\">"
.$icon. format_string($course->fullname) . "</a>";
}

0 comments on commit 0291a8b

Please sign in to comment.