Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

MDL-34573 accessibility compliance for tag: Add forform input text an…

…d select tag
  • Loading branch information...
commit 0327dda4ac7d1987692b39a2227c1fd7207491a5 1 parent c8ac480
rwijaya rwijaya authored

Showing 2 changed files with 12 additions and 6 deletions. Show diff stats Hide diff stats

  1. +7 4 tag/coursetags_edit.php
  2. +5 2 tag/manage.php
11 tag/coursetags_edit.php
@@ -159,11 +159,12 @@
159 159 <div class="coursetag_edit_centered">
160 160 <div class="coursetag_edit_row">
161 161 <div class="coursetag_edit_left">
162   - $edittagthisunit
  162 + <label for="coursetag_new_tag">$edittagthisunit</label>
163 163 </div>
164 164 <div class="coursetag_edit_right">
165 165 <div class="coursetag_form_input1">
166   - <input type="text" name="coursetag_sug_keyword" class="coursetag_form_input1a" disabled="disabled" />
  166 + <label clas="accesshide" for="coursetag_sug_keyword">$edittagthisunit</label>
  167 + <input type="text" name="coursetag_sug_keyword" id="coursetag_sug_keyword" class="coursetag_form_input1a" disabled="disabled" />
167 168 </div>
168 169 <div class="coursetag_form_input2">
169 170 <input type="text" name="coursetag_new_tag" id="coursetag_new_tag" class="coursetag_form_input2a"
@@ -182,10 +183,12 @@
182 183 $outstr .= <<<EOT1
183 184 <div class="coursetag_edit_row">
184 185 <div class="coursetag_edit_left">
185   - $editdeletemytag
  186 + <label for="del_tag">
  187 + $editdeletemytag
  188 + </label>
186 189 </div>
187 190 <div class="coursetag_edit_right">
188   - <select name="del_tag">
  191 + <select id="del_tag" name="del_tag">
189 192 $selectoptions
190 193 </select>
191 194 </div>
7 tag/manage.php
@@ -260,8 +260,10 @@
260 260 $flag = $tag->flag;
261 261 $timemodified = format_time(time() - $tag->timemodified);
262 262 $checkbox = '<input type="checkbox" name="tagschecked[]" value="'.$tag->id.'" />';
263   - $text = '<input type="text" name="newname['.$tag->id.']" />';
264   - $tagtype = html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false);
  263 + $text = html_writer::label(get_string('newname', 'tag'), 'newname_' . $tag->id, false, array('class' => 'accesshide'));
  264 + $text .= '<input type="text" id="newname_' . $tag->id. '" name="newname['.$tag->id.']" />';
  265 + $tagtype = html_writer::label(get_string('tagtype', 'tag'), 'menutagtypes'. $tag->id, false, array('class' => 'accesshide'));
  266 + $tagtype .= html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false, array('id' => 'menutagtypes'. $tag->id));
265 267
266 268 //if the tag if flagged, highlight it
267 269 if ($tag->flag > 0) {
@@ -283,6 +285,7 @@
283 285 echo '<input type="button" onclick="checknone()" value="'.get_string('deselectall').'" /> ';
284 286 echo '<input type="hidden" name="sesskey" value="'.sesskey().'" /> ';
285 287 echo '<br/><br/>';
  288 + echo html_writer::label(get_string('withselectedtags', 'tag'), 'menuformaction', false, array('class' => 'accesshide'));
286 289 echo '<select id="menuformaction" name="action">
287 290 <option value="" selected="selected">'. get_string('withselectedtags', 'tag') .'</option>
288 291 <option value="reset">'. get_string('resetflag', 'tag') .'</option>

0 comments on commit 0327dda

Please sign in to comment.
Something went wrong with that request. Please try again.