Permalink
Browse files

MDL-25186: add environmental check to recommend PHP 5.3.3

  • Loading branch information...
1 parent 0300e58 commit 059518944a163f8c26ac944096364e70dbea4f64 Rossiani Wijaya committed Dec 23, 2010
Showing with 14 additions and 0 deletions.
  1. +5 −0 admin/environment.xml
  2. +1 −0 lang/en_utf8/admin.php
  3. +8 −0 lib/customcheckslib.php
View
@@ -321,6 +321,11 @@
</PHP_SETTING>
</PHP_SETTINGS>
<CUSTOM_CHECKS>
+ <CUSTOM_CHECK file="lib/customcheckslib.php" function="php_check_php533" level="optional">
+ <FEEDBACK>
+ <ON_CHECK message="php533warning" />
+ </FEEDBACK>
+ </CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
</COMPATIBILITY_MATRIX>
View
@@ -588,6 +588,7 @@
$string['pgcluster'] = 'PostgreSQL Cluster';
$string['pgclusterdescription'] = 'PostgreSQL version/cluster parameter for command line operations. If you only have one postgresql on your system or you are not sure what this is, leave this blank.';
$string['php50restricted'] = 'PHP 5.0.x has a number of known problems, please upgrade to 5.1.x or downgrade to 4.3.x or 4.4.x';
+$string['php533warning'] = 'PHP 5.3.3 and upwards is recommended';
$string['phpfloatproblem'] = 'Detected unexpected problem in handling of PHP float numbers - $a';
$string['pleaseregister'] = 'Please register your site to remove this button';
$string['pleaserefreshregistration'] = 'Your site has been registered with moodle.org, please consider updating the registration if significant changes happened since your last update, on $a';
View
@@ -54,4 +54,12 @@ function php_check_register_globals($result) {
return $result;
}
+function php_check_php533($result) {
+ if (version_compare(phpversion(), '5.3.3') < 0) {
+ $result->status = false;
+ } else {
+ $result = null;
+ }
+ return $result;
+}
?>

0 comments on commit 0595189

Please sign in to comment.