Permalink
Browse files

MDL-35023 qtype calculated: fix strict syntax problem.

  • Loading branch information...
1 parent bac15e5 commit 07eca71195b7bd36cbe419f9bf3624abc76a0f26 @timhunt timhunt committed Aug 23, 2012
Showing with 8 additions and 6 deletions.
  1. +8 −6 question/type/calculated/questiontype.php
@@ -1701,17 +1701,19 @@ public function print_dataset_definitions_category_shared($question, $datasetdef
WHERE i.id = d.datasetdefinition AND i.category = ?";
if ($records = $DB->get_records_sql($sql, array($category))) {
foreach ($records as $r) {
+ $key = "$r->type-$r->category-$r->name";
$sql1 = "SELECT q.*
FROM {question} q
WHERE q.id = ?";
- if (!isset ($datasetdefs["$r->type-$r->category-$r->name"])) {
- $datasetdefs["$r->type-$r->category-$r->name"]= $r;
+ if (!isset($datasetdefs[$key])) {
+ $datasetdefs[$key] = $r;
}
if ($questionb = $DB->get_records_sql($sql1, array($r->question))) {
- $datasetdefs["$r->type-$r->category-$r->name"]->questions[
- $r->question]->name = $questionb[$r->question]->name;
- $datasetdefs["$r->type-$r->category-$r->name"]->questions[
- $r->question]->id = $questionb[$r->question]->id;
+ $datasetdefs[$key]->questions[$r->question] = new stdClass();
+ $datasetdefs[$key]->questions[$r->question]->name =
+ $questionb[$r->question]->name;
+ $datasetdefs[$key]->questions[$r->question]->id =
+ $questionb[$r->question]->id;
}
}
}

0 comments on commit 07eca71

Please sign in to comment.