Permalink
Browse files

MDL-34352 Convert chooserdialogue IDs to classes

  • Loading branch information...
andrewnicols committed Jul 16, 2012
1 parent 3294034 commit 0a2fb91003a1505ec26fb7ccc2f0c908ad0a30af
Showing with 6 additions and 8 deletions.
  1. +3 −3 course/renderer.php
  2. +0 −2 course/yui/modchooser/modchooser.js
  3. +3 −3 lib/yui/chooserdialogue/chooserdialogue.js
View
@@ -176,7 +176,7 @@ public function course_modchooser($modules, $course) {
$formcontent .= html_writer::tag('input', '', array('type' => 'hidden', 'id' => 'course',
'name' => 'course', 'value' => $course->id));
$formcontent .= html_writer::tag('input', '',
- array('type' => 'hidden', 'id' => 'jump', 'name' => 'jump', 'value' => ''));
+ array('type' => 'hidden', 'class' => 'jump', 'name' => 'jump', 'value' => ''));
$formcontent .= html_writer::tag('input', '', array('type' => 'hidden', 'name' => 'sesskey',
'value' => sesskey()));
$formcontent .= html_writer::end_tag('div');
@@ -209,9 +209,9 @@ public function course_modchooser($modules, $course) {
$formcontent .= html_writer::start_tag('div', array('class' => 'submitbuttons'));
$formcontent .= html_writer::tag('input', '',
- array('type' => 'submit', 'name' => 'submitbutton', 'id' => 'submitbutton', 'value' => get_string('add')));
+ array('type' => 'submit', 'name' => 'submitbutton', 'class' => 'submitbutton', 'value' => get_string('add')));
$formcontent .= html_writer::tag('input', '',
- array('type' => 'submit', 'name' => 'addcancel', 'id' => 'addcancel', 'value' => get_string('cancel')));
+ array('type' => 'submit', 'name' => 'addcancel', 'class' => 'addcancel', 'value' => get_string('cancel')));
$formcontent .= html_writer::end_tag('div');
$formcontent .= html_writer::end_tag('form');
@@ -28,8 +28,6 @@ YUI.add('moodle-course-modchooser', function(Y) {
};
this.setup_chooser_dialogue(dialogue, header, params);
- this.jumplink = this.container.one('#jump');
-
// Initialize existing sections and register for dynamically created sections
this.setup_for_section();
M.course.coursebase.register_module(this);
@@ -118,7 +118,7 @@ YUI.add('moodle-core-chooserdialogue', function(Y) {
}, this);
// Hook onto the cancel button to hide the form
- thisevent = this.container.one('#addcancel').on('click', this.cancel_popup, this);
+ thisevent = this.container.one('.addcancel').on('click', this.cancel_popup, this);
this.listenevents.push(thisevent);
thisevent = bb.one('div.closebutton').on('click', this.cancel_popup, this);
this.listenevents.push(thisevent);
@@ -128,8 +128,8 @@ YUI.add('moodle-core-chooserdialogue', function(Y) {
this.listenevents.push(thisevent);
// Add references to various elements we adjust
- this.jumplink = this.container.one('#jump');
- this.submitbutton = this.container.one('#submitbutton');
+ this.jumplink = this.container.one('.jump');
+ this.submitbutton = this.container.one('.submitbutton');
// Disable the submit element until the user makes a selection
this.submitbutton.set('disabled', 'true');

0 comments on commit 0a2fb91

Please sign in to comment.