Permalink
Browse files

MDL-39964 report_progress: don't browser sniff for SVG support

Use feature detection, its more robust and better practice.
  • Loading branch information...
1 parent f36066f commit 0a8985843e01fbd4fea0774a6ab23a2f545469fd @danpoltawski danpoltawski committed May 31, 2013
Showing with 11 additions and 7 deletions.
  1. +2 −7 report/progress/index.php
  2. +9 −0 report/progress/textrotate.js
@@ -146,8 +146,6 @@ function csv_quote($value) {
$line="\n";
}
} else {
- // Use SVG to draw sideways text if supported
- $svgcleverness = can_use_rotated_text();
// Navigation and header
$strreports = get_string("reports");
@@ -156,11 +154,8 @@ function csv_quote($value) {
$PAGE->set_title($strcompletion);
$PAGE->set_heading($course->fullname);
echo $OUTPUT->header();
-
- if ($svgcleverness) {
- $PAGE->requires->js('/report/progress/textrotate.js');
- $PAGE->requires->js_function_call('textrotate_init', null, true);
- }
+ $PAGE->requires->js('/report/progress/textrotate.js');
+ $PAGE->requires->js_function_call('textrotate_init', null, true);
// Handle groups (if enabled)
groups_print_course_menu($course,$CFG->wwwroot.'/report/progress/?course='.$course->id);
@@ -48,7 +48,16 @@ function textrotate_make_svg(el)
el.parentNode.removeChild(el);
}
+function browser_supports_svg() {
+ return document.implementation.hasFeature("http://www.w3.org/TR/SVG11/feature#BasicStructure", "1.1");
+}
+
function textrotate_init() {
+ if (!browser_supports_svg()) {
+ // Feature detect, else bail.
+ return;
+ }
+
YUI().use('yui2-dom', function(Y) {
var elements= Y.YUI2.util.Dom.getElementsByClassName('completion-activityname', 'span');
for(var i=0;i<elements.length;i++)

0 comments on commit 0a89858

Please sign in to comment.