Skip to content
Browse files

MDL-39832 Files: Fixed ETag format according with RFC2616.

ETag must be double quoted,
http://tools.ietf.org/html/rfc2616#section-3.11:

      entity-tag = [ weak ] opaque-tag
      weak       = "W/"
      opaque-tag = quoted-string
  • Loading branch information...
1 parent 627dc76 commit 0ba744205e0dc960f6cd870ad4e05a8b72448c9a @scara scara committed Jun 1, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/filelib.php
View
2 lib/filelib.php
@@ -1956,7 +1956,7 @@ function readfile_accel($file, $mimetype, $accelerate) {
header('Last-Modified: '. gmdate('D, d M Y H:i:s', $lastmodified) .' GMT');
if (is_object($file)) {
- header('ETag: ' . $file->get_contenthash());
+ header('Etag: "' . $file->get_contenthash() . '"');
if (isset($_SERVER['HTTP_IF_NONE_MATCH']) and $_SERVER['HTTP_IF_NONE_MATCH'] === $file->get_contenthash()) {
header('HTTP/1.1 304 Not Modified');
return;

0 comments on commit 0ba7442

Please sign in to comment.
Something went wrong with that request. Please try again.