From 0c053c536821492c2edbec19ea9cc0516b6a72bb Mon Sep 17 00:00:00 2001 From: Andrew Robert Nicols Date: Thu, 3 May 2012 15:02:10 +0100 Subject: [PATCH] MDL-32508 Add error when trying to access an unknown course section --- course/format/renderer.php | 6 ++++++ lang/en/error.php | 1 + 2 files changed, 7 insertions(+) diff --git a/course/format/renderer.php b/course/format/renderer.php index e71f2a58b521c..510de038e4d9e 100644 --- a/course/format/renderer.php +++ b/course/format/renderer.php @@ -419,6 +419,12 @@ public function print_single_section_page($course, $sections, $mods, $modnames, $context = context_course::instance($course->id); $canviewhidden = has_capability('moodle/course:viewhiddensections', $context); + if (!isset($sections[$displaysection])) { + // This section doesn't exist + print_error('unknowncoursesection', 'error', null, $course->fullname); + return; + } + if (!$sections[$displaysection]->visible && !$canviewhidden) { if (!$course->hiddensections) { echo $this->start_section_list(); diff --git a/lang/en/error.php b/lang/en/error.php index ad5affc867c9c..0d45834b6e2c3 100644 --- a/lang/en/error.php +++ b/lang/en/error.php @@ -475,6 +475,7 @@ $string['unknowncontext'] = 'This is an unknown context.'; $string['unknowncourse'] = 'Unknown course named "{$a}"'; $string['unknowncourseidnumber'] = 'Unknown course ID "{$a}"'; +$string['unknowncoursesection'] = 'Unknown course section in course "{$a}"'; $string['unknowncourserequest'] = 'Unknown course request'; $string['unknownfiletype'] = 'Error unknown filtertype'; $string['unknowngroup'] = 'Unknown group "{$a}"';