MDL-32508 Add error when trying to access an unknown course section

moodle · May 4, 2012 · 0c053c5 · 0c053c5
1 parent 3df72f8
commit 0c053c5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/course/format/renderer.php b/course/format/renderer.php
@@ -419,6 +419,12 @@ public function print_single_section_page($course, $sections, $mods, $modnames,
         $context = context_course::instance($course->id);
         $canviewhidden = has_capability('moodle/course:viewhiddensections', $context);
 
+        if (!isset($sections[$displaysection])) {
+            // This section doesn't exist
+            print_error('unknowncoursesection', 'error', null, $course->fullname);
+            return;
+        }
+
         if (!$sections[$displaysection]->visible && !$canviewhidden) {
             if (!$course->hiddensections) {
                 echo $this->start_section_list();

diff --git a/lang/en/error.php b/lang/en/error.php
@@ -475,6 +475,7 @@
 $string['unknowncontext'] = 'This is an unknown context.';
 $string['unknowncourse'] = 'Unknown course named "{$a}"';
 $string['unknowncourseidnumber'] = 'Unknown course ID "{$a}"';
+$string['unknowncoursesection'] = 'Unknown course section in course "{$a}"';
 $string['unknowncourserequest'] = 'Unknown course request';
 $string['unknownfiletype'] = 'Error unknown filtertype';
 $string['unknowngroup'] = 'Unknown group "{$a}"';