Permalink
Browse files

MDL-36170 - mod/data - Don't display the blocks editing button within…

… table HTML, use a standard API to create it.
  • Loading branch information...
1 parent 6548ce0 commit 0c665d0063379f4c361d9bc01e70d942e2fbf081 @jfilip jfilip committed Oct 29, 2012
Showing with 10 additions and 5 deletions.
  1. +10 −5 mod/data/view.php
View
15 mod/data/view.php
@@ -300,11 +300,16 @@
$title = $courseshortname.': ' . format_string($data->name);
if ($PAGE->user_allowed_editing()) {
- $buttons = '<table><tr><td><form method="get" action="view.php"><div>'.
- '<input type="hidden" name="id" value="'.$cm->id.'" />'.
- '<input type="hidden" name="edit" value="'.($PAGE->user_is_editing()?'off':'on').'" />'.
- '<input type="submit" value="'.get_string($PAGE->user_is_editing()?'blockseditoff':'blocksediton').'" /></div></form></td></tr></table>';
- $PAGE->set_button($buttons);
+ // Change URL parameter and block display string value depending on whether editing is enabled or not
+ if ($PAGE->user_is_editing()) {
+ $urlediting = 'off';
+ $strediting = get_string('blockseditoff');
+ } else {
+ $urlediting = 'on';
+ $strediting = get_string('blocksediton');
+ }
+ $url = new moodle_url($CFG->wwwroot.'/mod/data/view.php', array('id' => $cm->id, 'edit' => $urlediting));
+ $PAGE->set_button($OUTPUT->single_button($url, $strediting));
}
if ($mode == 'asearch') {

0 comments on commit 0c665d0

Please sign in to comment.