Skip to content
Browse files

MDL-37233 do not show skype status icon on https sites

Funny that the same company that implemented the IE security warnings is unable to set up SSL on the Skype status server…
  • Loading branch information...
1 parent 322af44 commit 0fe16db123fdee75f8699aacf5ae426cb105e2ff @skodak skodak committed
Showing with 7 additions and 3 deletions.
  1. +7 −3 user/profile.php
View
10 user/profile.php
@@ -297,9 +297,13 @@
}
if ($user->skype && !isset($hiddenfields['skypeid'])) {
- print_row(get_string('skypeid').':','<a href="skype:'.urlencode($user->skype).'?call">'.s($user->skype).
- ' <img src="http://mystatus.skype.com/smallicon/'.urlencode($user->skype).'" alt="'.get_string('status').'" '.
- ' /></a>');
+ if (strpos($CFG->httpswwwroot, 'https:') === 0) {
+ // Bad luck, skype devs are lazy to set up SSL on their servers - see MDL-37233.
+ $statusicon = '';
+ } else {
+ $statusicon = ' '.html_writer::empty_tag('img', array('src'=>'http://mystatus.skype.com/smallicon/'.urlencode($user->skype), 'alt'=>get_string('status')));
+ }
+ print_row(get_string('skypeid').':','<a href="skype:'.urlencode($user->skype).'?call">'.s($user->skype).$statusicon.'</a>');
}
if ($user->yahoo && !isset($hiddenfields['yahooid'])) {
print_row(get_string('yahooid').':', '<a href="http://edit.yahoo.com/config/send_webmesg?.target='.urlencode($user->yahoo).'&amp;.src=pg">'.s($user->yahoo)." <img src=\"http://opi.yahoo.com/online?u=".urlencode($user->yahoo)."&m=g&t=0\" alt=\"\"></a>");

0 comments on commit 0fe16db

Please sign in to comment.
Something went wrong with that request. Please try again.