Permalink
Browse files

MDL-27550 workshop: fixed XHTML strictness of H3 and A combo

H3 is block level element while A is in-line element in XHTML.
Credit goes to Sam Hemelryk for spotting this during the peer-review.
  • Loading branch information...
1 parent 08282ec commit 11351de2d35c76dc5b7072e56e69f174a7c62732 @mudrd8mz mudrd8mz committed Aug 2, 2011
Showing with 4 additions and 4 deletions.
  1. +4 −4 mod/workshop/renderer.php
@@ -92,14 +92,14 @@ protected function render_workshop_submission(workshop_submission $submission) {
$o .= $this->output->container_start($classes);
$o .= $this->output->container_start('header');
- $title = $this->output->heading(format_string($submission->title), 3, 'title');
+ $title = format_string($submission->title);
if ($this->page->url != $submission->url) {
- $o .= html_writer::link($submission->url, $title);
- } else {
- $o .= $title;
+ $title = html_writer::link($submission->url, $title);
}
+ $o .= $this->output->heading($title, 3, 'title');
+
if (!$anonymous) {
$author = new stdclass();
$author->id = $submission->authorid;

0 comments on commit 11351de

Please sign in to comment.