Merge branch 'MDL-61858_33' of git://github.com/markn86/moodle into MOODLE_33_STABLE

David Monllao · David Monllao · commit 156034995642 · 2018-05-11T18:07:16.000+02:00
diff --git a/grade/grading/form/guide/classes/privacy/provider.php b/grade/grading/form/guide/classes/privacy/provider.php
@@ -37,6 +37,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements
+        \core_privacy\local\metadata\provider,
         \core_privacy\local\request\user_preference_provider {
 
     /**
diff --git a/portfolio/boxnet/classes/privacy/provider.php b/portfolio/boxnet/classes/privacy/provider.php
@@ -36,6 +36,7 @@
 class provider implements
     // This portfolio plugin does not store any data itself.
     // It has no database tables, and it purely acts as a conduit, sending data externally.
+    \core_privacy\local\metadata\provider,
     \core_portfolio\privacy\portfolio_provider {
 
     /**
diff --git a/portfolio/flickr/classes/privacy/provider.php b/portfolio/flickr/classes/privacy/provider.php
@@ -36,6 +36,7 @@
 class provider implements
         // This portfolio plugin does not store any data itself.
         // It has no database tables, and it purely acts as a conduit, sending data externally.
+        \core_privacy\local\metadata\provider,
         \core_portfolio\privacy\portfolio_provider {
 
     /**
diff --git a/portfolio/googledocs/classes/privacy/provider.php b/portfolio/googledocs/classes/privacy/provider.php
@@ -36,6 +36,7 @@
 class provider implements
         // This portfolio plugin does not store any data itself.
         // It has no database tables, and it purely acts as a conduit, sending data externally.
+        \core_privacy\local\metadata\provider,
         \core_portfolio\privacy\portfolio_provider {
 
     /**
diff --git a/portfolio/mahara/classes/privacy/provider.php b/portfolio/mahara/classes/privacy/provider.php
@@ -36,6 +36,7 @@
 class provider implements
         // This portfolio plugin does not store any data itself.
         // It has no database tables, and it purely acts as a conduit, sending data externally.
+        \core_privacy\local\metadata\provider,
         \core_portfolio\privacy\portfolio_provider {
 
     /**
diff --git a/portfolio/picasa/classes/privacy/provider.php b/portfolio/picasa/classes/privacy/provider.php
@@ -36,6 +36,7 @@
 class provider implements
         // This portfolio plugin does not store any data itself.
         // It has no database tables, and it purely acts as a conduit, sending data externally.
+        \core_privacy\local\metadata\provider,
         \core_portfolio\privacy\portfolio_provider {
 
     /**
diff --git a/privacy/tests/provider_test.php b/privacy/tests/provider_test.php
@@ -163,6 +163,18 @@ public function test_metadata_provider($component, $classname) {
         }
     }
 
+    /**
+     * Test that all providers implement some form of compliant provider.
+     *
+     * @dataProvider get_component_list
+     * @param string $component frankenstyle component name, e.g. 'mod_assign'
+     * @param string $classname the fully qualified provider classname
+     */
+    public function test_all_providers_compliant($component, $classname) {
+        $manager = new manager();
+        $this->assertTrue($manager->component_is_compliant($component));
+    }
+
     /**
      * Data provider for the metadata\provider tests.
      *

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,18 @@ public function test_metadata_provider($component, $classname) {`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`
	`166`	`+ /**`
	`167`	`+ * Test that all providers implement some form of compliant provider.`
	`168`	`+ *`
	`169`	`+ * @dataProvider get_component_list`
	`170`	`+ * @param string $component frankenstyle component name, e.g. 'mod_assign'`
	`171`	`+ * @param string $classname the fully qualified provider classname`
	`172`	`+ */`
	`173`	`+ public function test_all_providers_compliant($component, $classname) {`
	`174`	`+ $manager = new manager();`
	`175`	`+ $this->assertTrue($manager->component_is_compliant($component));`
	`176`	`+ }`
	`177`	`+`
`166`	`178`	`/**`
`167`	`179`	`* Data provider for the metadata\provider tests.`
`168`	`180`	`*`