Permalink
Browse files

MDL-38101 Completion: Error when teacher/admin marks activity complete

  • Loading branch information...
1 parent 9130843 commit 1716b4a54b3781d34abd941637f97429a533330b @sammarshallou sammarshallou committed Feb 19, 2013
Showing with 6 additions and 3 deletions.
  1. +6 −3 course/togglecompletion.php
@@ -138,14 +138,17 @@
print_error('error');
}
-// Now change state
+// Set up completion object and check it is enabled.
$completion = new completion_info($course);
if (!$completion->is_enabled()) {
throw new moodle_exception('completionnotenabled', 'completion');
-} elseif (!$completion->is_tracked_user($USER->id)) {
- throw new moodle_exception('nottracked', 'completion');
}
+// NOTE: All users are allowed to toggle their completion state, including
+// users for whom completion information is not directly tracked. (I.e. even
+// if you are a teacher, or admin who is not enrolled, you can still toggle
+// your own completion state. You just don't appear on the reports.)
+
// Check completion state is manual
if($cm->completion != COMPLETION_TRACKING_MANUAL) {
error_or_ajax('cannotmanualctrack', $fromajax);

0 comments on commit 1716b4a

Please sign in to comment.