Permalink
Browse files

MDL-30901 gradereport_grader Removing screenreader usage and adding a…

…ria elements to grader cells
  • Loading branch information...
1 parent 36ab2fe commit 19db454f36c746e6010924de75ed63b9f27b939d @dmonllao dmonllao committed Sep 17, 2012
Showing with 3 additions and 3 deletions.
  1. +1 −2 grade/report/grader/lib.php
  2. +2 −1 grade/report/grader/module.js
View
3 grade/report/grader/lib.php
@@ -615,7 +615,6 @@ public function get_left_rows() {
$rows = array();
$showuserimage = $this->get_pref('showuserimage');
- $fixedstudents = $this->is_fixed_students();
$strfeedback = $this->get_lang_string("feedback");
$strgrade = $this->get_lang_string('grade');
@@ -1639,7 +1638,7 @@ public function process_action($target, $action) {
*/
public function is_fixed_students() {
global $USER, $CFG;
- return empty($USER->screenreader) && $CFG->grade_report_fixedstudents &&
+ return $CFG->grade_report_fixedstudents &&
(check_browser_version('MSIE', '7.0') ||
check_browser_version('Firefox', '2.0') ||
check_browser_version('Gecko', '2006010100') ||
View
3 grade/report/grader/module.js
@@ -56,7 +56,7 @@ M.gradereport_grader = {
return;
}
- var content = '<div class="graderreportoverlay">';
+ var content = '<div class="graderreportoverlay" role="tooltip" aria-describedby="' + properties.id + '">';
content += '<div class="fullname">'+properties.username+'</div><div class="itemname">'+properties.itemname+'</div>';
if (properties.feedback) {
content += '<div class="feedback">'+properties.feedback+'</div>';
@@ -241,6 +241,7 @@ M.gradereport_grader.classes.report.prototype.get_cell_info = function(arg) {
}
return {
+ id : cell.getAttribute('id'),
userid : userid,
username : this.users[userid],
itemid : itemid,

0 comments on commit 19db454

Please sign in to comment.