Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-38144 categories are created in reverse sort order in externallib

  • Loading branch information...
commit 1a9d07fb59147881b4615d1b2197076344046e01 1 parent 56d22f1
Marina Glancy marinaglancy authored
Showing with 6 additions and 3 deletions.
  1. +0 −1  course/externallib.php
  2. +6 −2 course/tests/externallib_test.php
1  course/externallib.php
View
@@ -1472,7 +1472,6 @@ public static function create_categories($categories) {
$newcategory = new stdClass();
$newcategory->name = $category['name'];
$newcategory->parent = $category['parent'];
- $newcategory->sortorder = 999; // Same as in the course/editcategory.php .
// Format the description.
if (!empty($category['description'])) {
$newcategory->description = $category['description'];
8 course/tests/externallib_test.php
View
@@ -111,8 +111,12 @@ public function test_create_categories() {
$category2 = $DB->get_record('course_categories', array('id' => $category2->id));
$category3 = $DB->get_record('course_categories', array('id' => $category3->id));
- $this->assertGreaterThanOrEqual($category1->sortorder, $category3->sortorder);
- $this->assertGreaterThanOrEqual($category2->sortorder, $category3->sortorder);
+ // sortorder sequence (and sortorder) must be:
+ // category 1
+ // category 3
+ // category 2
+ $this->assertGreaterThan($category1->sortorder, $category3->sortorder);
+ $this->assertGreaterThan($category3->sortorder, $category2->sortorder);
// Call without required capability
$this->unassignUserCapability('moodle/category:manage', $contextid, $roleid);
Please sign in to comment.
Something went wrong with that request. Please try again.