From 73c8d34ab817358ea89c44efb36f564dda41766b Mon Sep 17 00:00:00 2001 From: Davo Smith Date: Mon, 22 Oct 2018 11:24:17 +0100 Subject: [PATCH 1/2] MDL-63727 mod_scorm: fix typo in sco_launched URL --- mod/scorm/classes/event/sco_launched.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/scorm/classes/event/sco_launched.php b/mod/scorm/classes/event/sco_launched.php index 06b66d2bb67f6..a26d221ae6bd5 100644 --- a/mod/scorm/classes/event/sco_launched.php +++ b/mod/scorm/classes/event/sco_launched.php @@ -76,7 +76,7 @@ public static function get_name() { * @return \moodle_url */ public function get_url() { - return new \moodle_url('/mod/scorm/player.php', array('id' => $this->contextinstanceid, 'scoid' => $this->objectid)); + return new \moodle_url('/mod/scorm/player.php', array('cm' => $this->contextinstanceid, 'scoid' => $this->objectid)); } /** From b193f7754d68175c7768b3f730c4b0511528a69b Mon Sep 17 00:00:00 2001 From: Matteo Scaramuccia Date: Wed, 31 Oct 2018 21:47:45 +0100 Subject: [PATCH 2/2] MDL-63727 mod_scorm: Fixed typo in test_launch_sco() --- mod/scorm/tests/externallib_test.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/scorm/tests/externallib_test.php b/mod/scorm/tests/externallib_test.php index 9beb1c2787084..00c5cdd865be8 100644 --- a/mod/scorm/tests/externallib_test.php +++ b/mod/scorm/tests/externallib_test.php @@ -855,7 +855,7 @@ public function test_launch_sco() { // Checking that the event contains the expected values. $this->assertInstanceOf('\mod_scorm\event\sco_launched', $event); $this->assertEquals($this->context, $event->get_context()); - $moodleurl = new \moodle_url('/mod/scorm/player.php', array('id' => $this->cm->id, 'scoid' => $sco->id)); + $moodleurl = new \moodle_url('/mod/scorm/player.php', array('cm' => $this->cm->id, 'scoid' => $sco->id)); $this->assertEquals($moodleurl, $event->get_url()); $this->assertEventContextNotUsed($event); $this->assertNotEmpty($event->get_name());