Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

MDL-20636 changes to core & questions upgrade code

Changes include:

    - fixing versions and requires to current weekly (2011060313)
    - fix essay wrong upgrade step. Review & test!
    - fix numerical missing savepoint.
  • Loading branch information...
commit 1db15c2718da2dca183f5c602029dc07c4419b3c 1 parent 54771d8
@stronk7 stronk7 authored timhunt committed
View
56 lib/db/upgrade.php
@@ -6113,7 +6113,7 @@ function xmldb_main_upgrade($oldversion) {
}
// Question engine 2 changes (14) start here
- if ($oldversion < 2011051200) {
+ if ($oldversion < 2011060300) {
// Changing the default of field penalty on table question to 0.3333333
$table = new xmldb_table('question');
$field = new xmldb_field('penalty');
@@ -6124,10 +6124,10 @@ function xmldb_main_upgrade($oldversion) {
$dbman->change_field_default($table, $field);
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051200);
+ upgrade_main_savepoint(true, 2011060300);
}
- if ($oldversion < 2011051201) {
+ if ($oldversion < 2011060301) {
// Rename field defaultgrade on table question to defaultmark
$table = new xmldb_table('question');
@@ -6141,10 +6141,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051201);
+ upgrade_main_savepoint(true, 2011060301);
}
- if ($oldversion < 2011051202) {
+ if ($oldversion < 2011060302) {
// Rename the question_attempts table to question_usages.
$table = new xmldb_table('question_attempts');
@@ -6153,10 +6153,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051202);
+ upgrade_main_savepoint(true, 2011060302);
}
- if ($oldversion < 2011051203) {
+ if ($oldversion < 2011060303) {
// Rename the modulename field to component ...
$table = new xmldb_table('question_usages');
@@ -6215,10 +6215,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051203);
+ upgrade_main_savepoint(true, 2011060303);
}
- if ($oldversion < 2011051204) {
+ if ($oldversion < 2011060304) {
// Define key contextid (foreign) to be added to question_usages
$table = new xmldb_table('question_usages');
@@ -6229,10 +6229,10 @@ function xmldb_main_upgrade($oldversion) {
$dbman->add_key($table, $key);
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051204);
+ upgrade_main_savepoint(true, 2011060304);
}
- if ($oldversion < 2011051205) {
+ if ($oldversion < 2011060305) {
// Changing precision of field component on table question_usages to (255)
// This was missed during the upgrade from old versions.
@@ -6245,10 +6245,10 @@ function xmldb_main_upgrade($oldversion) {
$dbman->change_field_precision($table, $field);
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051205);
+ upgrade_main_savepoint(true, 2011060305);
}
- if ($oldversion < 2011051206) {
+ if ($oldversion < 2011060306) {
// Define table question_attempts to be created
$table = new xmldb_table('question_attempts');
@@ -6296,10 +6296,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051206);
+ upgrade_main_savepoint(true, 2011060306);
}
- if ($oldversion < 2011051207) {
+ if ($oldversion < 2011060307) {
// Define table question_attempt_steps to be created
$table = new xmldb_table('question_attempt_steps');
@@ -6337,10 +6337,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051207);
+ upgrade_main_savepoint(true, 2011060307);
}
- if ($oldversion < 2011051208) {
+ if ($oldversion < 2011060308) {
// Define table question_attempt_step_data to be created
$table = new xmldb_table('question_attempt_step_data');
@@ -6370,10 +6370,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051208);
+ upgrade_main_savepoint(true, 2011060308);
}
- if ($oldversion < 2011051209) {
+ if ($oldversion < 2011060309) {
// Define table question_hints to be created
$table = new xmldb_table('question_hints');
@@ -6405,10 +6405,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051209);
+ upgrade_main_savepoint(true, 2011060309);
}
- if ($oldversion < 2011051210) {
+ if ($oldversion < 2011060310) {
// In the past, question_answer fractions were stored with rather
// sloppy rounding. Now update them to the new standard of 7 d.p.
@@ -6430,10 +6430,10 @@ function xmldb_main_upgrade($oldversion) {
}
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051210);
+ upgrade_main_savepoint(true, 2011060310);
}
- if ($oldversion < 2011051211) {
+ if ($oldversion < 2011060311) {
// In the past, question penalties were stored with rather
// sloppy rounding. Now update them to the new standard of 7 d.p.
@@ -6447,10 +6447,10 @@ function xmldb_main_upgrade($oldversion) {
'penalty', 1, 'penalty > 1');
// quiz savepoint reached
- upgrade_main_savepoint(true, 2011051211);
+ upgrade_main_savepoint(true, 2011060311);
}
- if ($oldversion < 2011051212) {
+ if ($oldversion < 2011060312) {
// Define field hintformat to be added to question_hints table.
$table = new xmldb_table('question_hints');
@@ -6462,10 +6462,10 @@ function xmldb_main_upgrade($oldversion) {
$dbman->add_field($table, $field);
}
- upgrade_main_savepoint(true, 2011051212);
+ upgrade_main_savepoint(true, 2011060312);
}
- if ($oldversion < 2011051213) {
+ if ($oldversion < 2011060313) {
// Define field variant to be added to question_attempts
$table = new xmldb_table('question_attempts');
$field = new xmldb_field('variant', XMLDB_TYPE_INTEGER, '10', XMLDB_UNSIGNED,
@@ -6477,7 +6477,7 @@ function xmldb_main_upgrade($oldversion) {
}
// Main savepoint reached
- upgrade_main_savepoint(true, 2011051213);
+ upgrade_main_savepoint(true, 2011060313);
}
// Question engine 2 changes (14) end here
View
2  question/type/calculated/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051900;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/calculatedmulti/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051900;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/calculatedsimple/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051900;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/description/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
15 question/type/essay/db/upgrade.php
@@ -70,14 +70,21 @@ function xmldb_qtype_essay_upgrade($oldversion) {
upgrade_plugin_savepoint(true, 2011031000, 'qtype', 'essay');
}
- if ($oldversion < 2011031000) {
+ if ($oldversion < 2011060300) {
// Insert a row into the qtype_essay_options table for each existing essay question.
$DB->execute("
INSERT INTO {qtype_essay_options} (questionid, responseformat,
responsefieldlines, attachments, graderinfo, graderinfoformat)
- SELECT id, 'editor', 15, 0, '', " . FORMAT_MOODLE . "
- FROM {question}
- WHERE qtype = 'essay'");
+ SELECT q.id, 'editor', 15, 0, '', " . FORMAT_MOODLE . "
+ FROM {question} q
+ WHERE q.qtype = 'essay'
+ AND NOT EXISTS (
+ SELECT 'x'
+ FROM {qtype_essay_options} qeo
+ WHERE qeo.questionid = q.id)");
+
+ // essay savepoint reached
+ upgrade_plugin_savepoint(true, 2011060300, 'qtype', 'essay');
}
return true;
View
4 question/type/essay/version.php
@@ -25,5 +25,5 @@
defined('MOODLE_INTERNAL') || die();
-$plugin->version = 2011031001;
-$plugin->requires = 2011051212;
+$plugin->version = 2011060300;
+$plugin->requires = 2011060313;
View
2  question/type/match/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/missingtype/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
4 question/type/multianswer/version.php
@@ -25,5 +25,5 @@
defined('MOODLE_INTERNAL') || die();
-$plugin->version = 2010090501;
-$plugin->requires = 2010090501;
+$plugin->version = 2011051200;
+$plugin->requires = 2011060313;
View
2  question/type/multichoice/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
7 question/type/numerical/db/upgrade.php
@@ -190,6 +190,9 @@ function xmldb_qtype_numerical_upgrade($oldversion) {
$DB->update_record('question', $updaterecord);
}
$rs->close();
+
+ // numerical savepoint reached
+ upgrade_plugin_savepoint(true, 2011042600, 'qtype', 'numerical');
}
if ($oldversion < 2011042601) {
@@ -223,7 +226,6 @@ function xmldb_qtype_numerical_upgrade($oldversion) {
return true;
}
-
/**
* Convert the ->questiontext and ->instructions fields to have the same text format.
* If they are already the same, do nothing. Otherwise, this method works by
@@ -253,6 +255,9 @@ function qtype_numerical_convert_text_format($numericaloptions) {
return true;
}
+// Add some helper functions that should be in upgradelib.php, but having there already
+// the question attempts updater classes prevents us to do so :-(
+
/**
* Convert some content to HTML.
* @param string $text the content to convert to HTML
View
2  question/type/numerical/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/random/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/shortanswer/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  question/type/truefalse/version.php
@@ -26,4 +26,4 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2011051200;
-$plugin->requires = 2011051212;
+$plugin->requires = 2011060313;
View
2  version.php
@@ -30,7 +30,7 @@
defined('MOODLE_INTERNAL') || die();
-$version = 2011060200.00; // YYYYMMDD = weekly release date of this DEV branch
+$version = 2011060313.00; // YYYYMMDD = weekly release date of this DEV branch
// RR = release increments - 00 in DEV branches
// .XX = incremental changes
Please sign in to comment.
Something went wrong with that request. Please try again.