Permalink
Browse files

MDL-29254 blog: added check in upgrade for summary and content to be …

…null fields
  • Loading branch information...
1 parent ad52027 commit 21144ea8c65d91259e5da8faed5c739d7afc66c2 Rajesh Taneja committed Feb 14, 2012
Showing with 31 additions and 1 deletion.
  1. +30 −0 lib/db/upgrade.php
  2. +1 −1 version.php
View
@@ -6992,6 +6992,36 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2011120500.03);
}
+ if ($oldversion < 2011120501.09) {
+ // Somewhere before 1.9 summary and content column in post table were not null. In 1.9+
+ // not null became false.
+ $columns = $DB->get_columns('post');
+
+ // Fix discrepancies in summary field after upgrade from 1.9
+ if (array_key_exists('summary', $columns) && $columns['summary']->not_null != false) {
+ $table = new xmldb_table('post');
+ $summaryfield = new xmldb_field('summary', XMLDB_TYPE_TEXT, 'big', null, null, null, null, 'subject');
+
+ if ($dbman->field_exists($table, $summaryfield)) {
+ $dbman->change_field_notnull($table, $summaryfield);
+ }
+
+ }
+
+ // Fix discrepancies in content field after upgrade from 1.9
+ if (array_key_exists('content', $columns) && $columns['content']->not_null != false) {
+ $table = new xmldb_table('post');
+ $contentfield = new xmldb_field('content', XMLDB_TYPE_TEXT, 'big', null, null, null, null, 'summary');
+
+ if ($dbman->field_exists($table, $contentfield)) {
+ $dbman->change_field_notnull($table, $contentfield);
+ }
+
+ }
+
+ upgrade_main_savepoint(true, 2011120501.09);
+ }
+
return true;
}
View
@@ -30,7 +30,7 @@
defined('MOODLE_INTERNAL') || die();
-$version = 2011120501.07; // 20111205 = branching date YYYYMMDD - do not modify!
+$version = 2011120501.09; // 20111205 = branching date YYYYMMDD - do not modify!
// RR = release increments - 00 in DEV branches
// .XX = incremental changes

0 comments on commit 21144ea

Please sign in to comment.