Permalink
Browse files

MDL-30955 rating: corrected /rating/index.php as it was determining t…

…he maximum rating incorrectly for custom scales
  • Loading branch information...
1 parent 3c4111e commit 211bb241de4f0e025acaef8b5820c74178c5d162 @andyjdavis andyjdavis committed Apr 10, 2012
Showing with 4 additions and 2 deletions.
  1. +4 −2 rating/index.php
View
@@ -102,8 +102,10 @@
$table->colclasses = array('', 'firstname', 'rating', 'time');
$table->data = array();
- //if the scale was changed after ratings were submitted some ratings may have a value above the current maximum
- $maxrating = count($scalemenu) - 1;
+ // If the scale was changed after ratings were submitted some ratings may have a value above the current maximum
+ // We can't just do count($scalemenu) - 1 as custom scales start at index 1, not 0
+ $maxrating = max(array_keys($scalemenu));
+
foreach ($ratings as $rating) {
//Undo the aliasing of the user id column from user_picture::fields()
//we could clone the rating object or preserve the rating id if we needed it again

0 comments on commit 211bb24

Please sign in to comment.