Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fix MDL-11632: Multiple files with emtpy lines outside PHP open/close…

… tags

There are multiple issues with Moodle files containing empty or blank lines
(lines consisting of white spaces or tabs only) and/or white space before or
after the PHP open and close tags, notably with config.php and theme files.
  • Loading branch information...
commit 23290eea4dc12a334f1b61082d53a8c48750135a 1 parent f050e82
iarenaza authored
Showing with 13 additions and 52 deletions.
  1. +0 −1  admin/uploaduser.php
  2. +0 −4 auth/cas/config.html
  3. +0 −1  auth/cas/forbidden.php
  4. +0 −1  auth/radius/lib.php
  5. +0 −1  course/import/groups/index.php
  6. +0 −1  course/info.php
  7. +0 −1  course/report/outline/index.php
  8. +0 −1  course/search.php
  9. +0 −1  course/user.php
  10. +0 −1  lib/adodb/lang/adodb-ar.inc.php
  11. +1 −2  lib/adodb/lang/adodb-bg.inc.php
  12. +2 −3 lib/adodb/lang/adodb-bgutf8.inc.php
  13. +1 −2  lib/adodb/lang/adodb-en.inc.php
  14. +1 −2  lib/adodb/lang/adodb-pl.inc.php
  15. +0 −1  lib/adodb/lang/adodb-ro.inc.php
  16. +6 −2 lib/adodb/readme_moodle.txt
  17. +0 −1  lib/languages.php
  18. +0 −1  login/change_password_form.html
  19. +0 −3  login/forgot_password.php
  20. +0 −1  mod/choice/index.php
  21. +0 −1  mod/exercise/assessments.php
  22. +1 −1  mod/glossary/tabs.html
  23. +0 −1  mod/journal/index.php
  24. +0 −1  mod/journal/report.php
  25. +0 −1  mod/label/view.php
  26. +0 −1  mod/lesson/action/confirmdelete.php
  27. +0 −1  mod/resource/index.php
  28. +1 −1  mod/resource/type/html/html.html
  29. +0 −1  mod/resource/type/repository/hive/openlitepublish.php
  30. +0 −1  mod/resource/type/repository/repository.html
  31. +0 −1  mod/resource/type/text/text.html
  32. +0 −1  mod/scorm/datamodel.php
  33. +0 −1  mod/survey/download.php
  34. +0 −1  mod/workshop/assess.php
  35. +0 −1  mod/workshop/assessments.php
  36. +0 −1  mod/workshop/upload.php
  37. +0 −1  mod/workshop/viewassessment.php
  38. +0 −1  question/export.php
  39. +0 −1  sso/hive/login.php
  40. +0 −2  theme/chameleon/ui/chameleon.php
View
1  admin/uploaduser.php
@@ -423,4 +423,3 @@ function my_file_get_contents($filename, $use_include_path = 0) {
}
?>
-
View
4 auth/cas/config.html
@@ -112,7 +112,3 @@
<?php
include($CFG->dirroot.'/auth/ldap/config.html');
?>
-
-
-
-
View
1  auth/cas/forbidden.php
@@ -15,4 +15,3 @@
print_footer();
exit;
?>
-
View
1  auth/radius/lib.php
@@ -47,4 +47,3 @@ function auth_user_login ($username, $password) {
$rauth->close();
}
?>
-
View
1  course/import/groups/index.php
@@ -212,4 +212,3 @@ function my_file_get_contents($filename, $use_include_path = 0) {
}
?>
-
View
1  course/info.php
@@ -81,4 +81,3 @@
close_window_button();
?>
-
View
1  course/report/outline/index.php
@@ -126,4 +126,3 @@ function print_outline_row($mod, $instance, $result) {
}
?>
-
View
1  course/search.php
@@ -263,4 +263,3 @@
?>
-
View
1  course/user.php
@@ -285,4 +285,3 @@ function print_outline_row($mod, $instance, $result) {
}
?>
-
View
1  lib/adodb/lang/adodb-ar.inc.php
@@ -31,4 +31,3 @@
DB_ERROR_ACCESS_VIOLATION => 'سماحيات غير كافية'
);
?>
-
View
3  lib/adodb/lang/adodb-bg.inc.php
@@ -34,5 +34,4 @@
DB_ERROR_NOSUCHDB => 'несъществуваща база данни',
DB_ERROR_ACCESS_VIOLATION => 'нямате достатъчно права'
);
-?>
-
+?>
View
5 lib/adodb/lang/adodb-bgutf8.inc.php
@@ -1,4 +1,4 @@
-<?php
+<?php
/*
Bulgarian language, v1.0, 25.03.2004, encoding by UTF-8 charset
contributed by Valentin Sheiretsky <valio#valio.eu.org>
@@ -34,5 +34,4 @@
DB_ERROR_NOSUCHDB => 'несъществуваща база данни',
DB_ERROR_ACCESS_VIOLATION => 'нямате достатъчно права'
);
-?>
-
+?>
View
3  lib/adodb/lang/adodb-en.inc.php
@@ -30,5 +30,4 @@
DB_ERROR_NOSUCHDB => 'no such database',
DB_ERROR_ACCESS_VIOLATION => 'insufficient permissions'
);
-?>
-
+?>
View
3  lib/adodb/lang/adodb-pl.inc.php
@@ -32,5 +32,4 @@
DB_ERROR_NOSUCHDB => 'nie znaleziono bazy',
DB_ERROR_ACCESS_VIOLATION => 'niedostateczne uprawnienia'
);
-?>
-
+?>
View
1  lib/adodb/lang/adodb-ro.inc.php
@@ -33,4 +33,3 @@
DB_ERROR_ACCESS_VIOLATION => 'permisiuni insuficiente'
);
?>
-
View
8 lib/adodb/readme_moodle.txt
@@ -20,6 +20,10 @@ Our changes:
for the annoying http://tracker.moodle.org/browse/MDL-6877.
Once fixed by adodb guys, we'll return to their official distro.
* removed bogus "_connec" from first line of adodb-postgres64.inc.php
+ * lang/adodb-ar.inc.php lang/adodb-bg.inc.php lang/adodb-bgutf8.inc.php
+ lang/adodb-en.inc.php lang/adodb-pl.inc.php lang/adodb-ro.inc.php
+ lang/adodb_th.inc.php - Removed leading/trailing white space outside PHP open/close tags
+ (see http://tracker.moodle.org/browse/MDL-11632).
-skodak
-11 October 2006
+skodak,iarenaza
+10 October 2007
View
1  lib/languages.php
@@ -335,4 +335,3 @@
?>
-
View
1  login/change_password_form.html
@@ -1,4 +1,3 @@
-
<?php
// only display this help message if we are being forced to change
if ($forcepassword) {
View
3  login/forgot_password.php
@@ -293,6 +293,3 @@
print_simple_box_end();
print_footer();
?>
-
-
-
View
1  mod/choice/index.php
@@ -91,4 +91,3 @@
print_footer($course);
?>
-
View
1  mod/exercise/assessments.php
@@ -1173,4 +1173,3 @@
print_footer($course);
?>
-
View
2  mod/glossary/tabs.html
@@ -107,4 +107,4 @@
break;
}
echo '<hr />';
-?>
+?>
View
1  mod/journal/index.php
@@ -56,4 +56,3 @@
print_footer($course);
?>
-
View
1  mod/journal/report.php
@@ -144,4 +144,3 @@
print_footer($course);
?>
-
View
1  mod/label/view.php
@@ -35,4 +35,3 @@
redirect("$CFG->wwwroot/course/view.php?id=$course->id");
?>
-
View
1  mod/lesson/action/confirmdelete.php
@@ -28,4 +28,3 @@
"lesson.php?action=delete&amp;id=$cm->id&amp;pageid=$pageid&amp;sesskey=".$USER->sesskey,
"view.php?id=$cm->id");
?>
-
View
1  mod/resource/index.php
@@ -89,4 +89,3 @@
print_footer($course);
?>
-
View
2  mod/resource/type/html/html.html
@@ -130,4 +130,4 @@
</td></tr>
-<?php print_visible_setting($form); ?>
+<?php print_visible_setting($form); ?>
View
1  mod/resource/type/repository/hive/openlitepublish.php
@@ -43,4 +43,3 @@
redirect($CFG->hiveprotocol .'://'. $CFG->hivehost .':'. $CFG->hiveport .''. $CFG->hivepath .'?'.$query);
?>
-
View
1  mod/resource/type/repository/repository.html
@@ -213,4 +213,3 @@
</td></tr>
<?php print_visible_setting($form); ?>
-
View
1  mod/resource/type/text/text.html
@@ -146,4 +146,3 @@
</td></tr>
<?php print_visible_setting($form); ?>
-
View
1  mod/scorm/datamodel.php
@@ -53,4 +53,3 @@
}
}
?>
-
View
1  mod/survey/download.php
@@ -239,4 +239,3 @@
?>
-
View
1  mod/workshop/assess.php
@@ -149,4 +149,3 @@
print_footer('none');
?>
-
View
1  mod/workshop/assessments.php
@@ -1363,4 +1363,3 @@
print_footer($course);
?>
-
View
1  mod/workshop/upload.php
@@ -117,4 +117,3 @@
print_footer($course);
?>
-
View
1  mod/workshop/viewassessment.php
@@ -89,4 +89,3 @@
print_footer('none');
?>
-
View
1  question/export.php
@@ -208,4 +208,3 @@
print_simple_box_end();
print_footer($course);
?>
-
View
1  sso/hive/login.php
@@ -20,4 +20,3 @@
}
?>
-
View
2  theme/chameleon/ui/chameleon.php
@@ -30,5 +30,3 @@
}
}
?>
-
-
Please sign in to comment.
Something went wrong with that request. Please try again.