Skip to content
Browse files

MDL-14635 remove tags from glossary block help

  • Loading branch information...
1 parent 062b6df commit 291f748a70e74ce297584c68403f59e7447f24ea jerome committed Jun 25, 2008
View
3 blocks/glossary_random/config_instance.html
@@ -26,8 +26,7 @@
<td align="right"><?php print_string("type","block_glossary_random") ?>:</td>
<td><?php
choose_from_menu($type, "type", $this->config->type, "");
- helpbutton("",get_string("type","block_glossary_random"),"moodle",true,false,get_string("typehelp","block_glossary_random"));
- // helpbutton("type_help", get_string("type_help", "block_glossary_random"), "block/glossary_random");
+ helpbutton('newentry', get_string("type","block_glossary_random"), 'glossary');
?></td>
</tr>
View
1 lang/en_utf8/block_glossary_random.php
@@ -20,7 +20,6 @@
$string['showconcept'] = 'Show concept (heading) for each entry';
$string['title'] = 'Title';
$string['type'] = 'How a new entry is chosen';
-$string['typehelp'] = '<b>Last modified entry</b> will always display the entry that was last modified, and <b>Random entry</b> will choose a new one at random every time. The option <b>Next entry</b> will cycle through the entries in order. This last option is especially useful when a number of days is also chosen, allowing you to make a <i>Quote of the week</i> or a <i>Tip of the day</i> that everyone sees.';
$string['viewglossary'] = 'More quotes...';
$string['whichfooter'] = 'You can display links to actions of the glossary this block is associated with. The block will only display links to actions which are enabled for that glossary.';
View
5 lang/en_utf8/help/glossary/newentry.html
@@ -0,0 +1,5 @@
+<b>Last modified entry</b> will always display the entry that was last modified,
+and <b>Random entry</b> will choose a new one at random every time. The option
+<b>Next entry</b> will cycle through the entries in order. This last option is
+especially useful when a number of days is also chosen, allowing you to make a
+<i>Quote of the week</i> or a <i>Tip of the day</i> that everyone sees.
View
7 lib/weblib.php
@@ -5860,6 +5860,13 @@ function helpbutton ($page, $title, $module='moodle', $image=true, $linktext=fal
$imagetext='') {
global $CFG, $COURSE;
+ //warning if ever $text parameter is used
+ //$text option won't work properly because the text needs to be always cleaned and,
+ // when cleaned... html tags always break, so it's unusable.
+ if ( isset($text) && $text!='') {
+ debugging('Warning: it\'s not recommended to use $text parameter in helpbutton ($page=' . $page . ', $module=' . $module . ') function');
+ }
+
// fix for MDL-7734
if (!empty($COURSE->lang)) {
$forcelang = $COURSE->lang;

0 comments on commit 291f748

Please sign in to comment.
Something went wrong with that request. Please try again.