diff --git a/mod/forum/lang/en/forum.php b/mod/forum/lang/en/forum.php index 599c5b33becc8..415c599418500 100644 --- a/mod/forum/lang/en/forum.php +++ b/mod/forum/lang/en/forum.php @@ -286,6 +286,8 @@ $string['longpost'] = 'Long post'; $string['mailnow'] = 'Send forum post notifications with no editing-time delay'; $string['manydiscussions'] = 'Discussions per page'; +$string['managesubscriptionsoff'] = 'Finish managing subscriptions'; +$string['managesubscriptionson'] = 'Manage subscriptions'; $string['markalldread'] = 'Mark all posts in this discussion read.'; $string['markallread'] = 'Mark all posts in this forum read.'; $string['markasreadonnotification'] = 'When sending forum post notifications'; diff --git a/mod/forum/lib.php b/mod/forum/lib.php index 8c5ec55900531..85510b745fbb6 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -6057,17 +6057,22 @@ function forum_update_subscriptions_button($courseid, $forumid) { global $CFG, $USER; if (!empty($USER->subscriptionsediting)) { - $string = get_string('turneditingoff'); + $string = get_string('managesubscriptionsoff', 'forum'); $edit = "off"; } else { - $string = get_string('turneditingon'); + $string = get_string('managesubscriptionson', 'forum'); $edit = "on"; } - return "
wwwroot/mod/forum/subscribers.php\">". - "". - "". - "
"; + $subscribers = html_writer::start_tag('form', array('action' => $CFG->wwwroot . '/mod/forum/subscribers.php', + 'method' => 'get', 'class' => 'form-inline')); + $subscribers .= html_writer::empty_tag('input', array('type' => 'submit', 'value' => $string, + 'class' => 'btn btn-secondary')); + $subscribers .= html_writer::empty_tag('input', array('type' => 'hidden', 'name' => 'id', 'value' => $forumid)); + $subscribers .= html_writer::empty_tag('input', array('type' => 'hidden', 'name' => 'edit', 'value' => $edit)); + $subscribers .= html_writer::end_tag('form'); + + return $subscribers; } // Functions to do with read tracking. diff --git a/mod/forum/subscribers.php b/mod/forum/subscribers.php index 953eeeb304600..16e403df628d7 100644 --- a/mod/forum/subscribers.php +++ b/mod/forum/subscribers.php @@ -104,12 +104,16 @@ if ($edit != -1) { $USER->subscriptionsediting = $edit; } - $PAGE->set_button(forum_update_subscriptions_button($course->id, $id)); + $updatesubscriptionsbutton = forum_update_subscriptions_button($course->id, $id); } else { + $updatesubscriptionsbutton = ''; unset($USER->subscriptionsediting); } echo $OUTPUT->header(); echo $OUTPUT->heading(get_string('forum', 'forum').' '.$strsubscribers); +if (!empty($updatesubscriptionsbutton)) { + echo \html_writer::div($updatesubscriptionsbutton, 'pull-right'); +} if (empty($USER->subscriptionsediting)) { $subscribers = \mod_forum\subscriptions::fetch_subscribed_users($forum, $currentgroup, $context); if (\mod_forum\subscriptions::is_forcesubscribed($forum)) { @@ -119,6 +123,9 @@ } else { echo $forumoutput->subscriber_selection_form($existingselector, $subscriberselector); } +if (!empty($updatesubscriptionsbutton)) { + echo $updatesubscriptionsbutton; +} echo $OUTPUT->footer(); /**