Permalink
Browse files

MDL-36204: moodle1 backup converter: add unit test to cover this issue

  • Loading branch information...
1 parent ba42721 commit 2b046f832b6aff08f00e19d7f5a6d1b73816adbb @pauln pauln committed Nov 14, 2012
Showing with 13 additions and 0 deletions.
  1. +13 −0 backup/converter/moodle1/simpletest/testlib.php
@@ -435,6 +435,19 @@ public function test_referenced_course_files() {
<br /><a href=\'$@FILEPHP@$$@SLASH@$MANUAL.DOC$@FORCEDOWNLOAD@$\'>download manual</a><br />');
}
+ public function test_referenced_files_urlencoded() {
+ // This test covers MDL-36204
+ $text = 'This is a text containing links to file.php
+as it is parsed from the backup file. <br /><br /><img border="0" width="110" vspace="0" hspace="0" height="92" title="News" alt="News" src="$@FILEPHP@$$@SLASH@$pics$@SLASH@$news.gif" /><a href="$@FILEPHP@$$@SLASH@$pics$@SLASH@$news.gif$@FORCEDOWNLOAD@$">no space</a><br />
+ <br /><a href=\'$@FILEPHP@$$@SLASH@$pics$@SLASH@$news%20with%20spaces.gif$@FORCEDOWNLOAD@$\'>with urlencoded spaces</a><br />';
+
+ $files = moodle1_converter::find_referenced_files($text);
+ $this->assertIsA($files, 'array');
+ $this->assertEqual(2, count($files));
+ $this->assertTrue(in_array('/pics/news.gif', $files));
+ $this->assertTrue(in_array('/pics/news with spaces.gif', $files));
+ }
+
public function test_question_bank_conversion() {
global $CFG;

0 comments on commit 2b046f8

Please sign in to comment.