Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge branch 'MDL-29454_20' of git://github.com/timhunt/moodle into M…

…OODLE_20_STABLE
  • Loading branch information...
commit 2f922905150122404dfdf019e055422313cef127 2 parents 422d1ed + becf8f8
@samhemelryk samhemelryk authored
Showing with 254 additions and 239 deletions.
  1. +254 −239 admin/qtypes.php
View
493 admin/qtypes.php
@@ -1,293 +1,308 @@
<?php
-// Allows the admin to manage question types.
-
- require_once(dirname(__FILE__) . '/../config.php');
- require_once($CFG->libdir . '/questionlib.php');
- require_once($CFG->libdir . '/adminlib.php');
- require_once($CFG->libdir . '/tablelib.php');
-
-/// Check permissions.
- require_login();
- $systemcontext = get_context_instance(CONTEXT_SYSTEM);
- require_capability('moodle/question:config', $systemcontext);
- $canviewreports = has_capability('report/questioninstances:view', $systemcontext);
-
- admin_externalpage_setup('manageqtypes');
-
-/// Get some data we will need - question counts and which types are needed.
- $counts = $DB->get_records_sql("
- SELECT qtype, COUNT(1) as numquestions, SUM(hidden) as numhidden
- FROM {question} GROUP BY qtype", array());
- $needed = array();
- foreach ($QTYPES as $qtypename => $qtype) {
- if (!isset($counts[$qtypename])) {
- $counts[$qtypename] = new stdClass;
- $counts[$qtypename]->numquestions = 0;
- $counts[$qtypename]->numhidden = 0;
- }
- $needed[$qtypename] = $counts[$qtypename]->numquestions > 0;
- $counts[$qtypename]->numquestions -= $counts[$qtypename]->numhidden;
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Allows the admin to manage question types.
+ *
+ * @package moodlecore
+ * @subpackage questionbank
+ * @copyright 2008 Tim Hunt
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+
+require_once(dirname(__FILE__) . '/../config.php');
+require_once($CFG->libdir . '/questionlib.php');
+require_once($CFG->libdir . '/adminlib.php');
+require_once($CFG->libdir . '/tablelib.php');
+
+// Check permissions.
+require_login();
+$systemcontext = get_context_instance(CONTEXT_SYSTEM);
+require_capability('moodle/question:config', $systemcontext);
+$canviewreports = has_capability('report/questioninstances:view', $systemcontext);
+
+admin_externalpage_setup('manageqtypes');
+$thispageurl = new moodle_url('/admin/qtypes.php');
+
+// Get some data we will need - question counts and which types are needed.
+$counts = $DB->get_records_sql("
+ SELECT qtype, COUNT(1) as numquestions, SUM(hidden) as numhidden
+ FROM {question} GROUP BY qtype", array());
+$needed = array();
+foreach ($QTYPES as $qtypename => $qtype) {
+ if (!isset($counts[$qtypename])) {
+ $counts[$qtypename] = new stdClass;
+ $counts[$qtypename]->numquestions = 0;
+ $counts[$qtypename]->numhidden = 0;
}
- $needed['missingtype'] = true; // The system needs the missing question type.
- foreach ($QTYPES as $qtypename => $qtype) {
- foreach ($qtype->requires_qtypes() as $reqtype) {
- $needed[$reqtype] = true;
- }
+ $needed[$qtypename] = $counts[$qtypename]->numquestions > 0;
+ $counts[$qtypename]->numquestions -= $counts[$qtypename]->numhidden;
+}
+$needed['missingtype'] = true; // The system needs the missing question type.
+foreach ($QTYPES as $qtypename => $qtype) {
+ foreach ($qtype->requires_qtypes() as $reqtype) {
+ $needed[$reqtype] = true;
}
- foreach ($counts as $qtypename => $count) {
- if (!isset($QTYPES[$qtypename])) {
- $counts['missingtype']->numquestions += $count->numquestions - $count->numhidden;
- $counts['missingtype']->numhidden += $count->numhidden;
- }
+}
+foreach ($counts as $qtypename => $count) {
+ if (!isset($QTYPES[$qtypename])) {
+ $counts['missingtype']->numquestions += $count->numquestions - $count->numhidden;
+ $counts['missingtype']->numhidden += $count->numhidden;
}
+}
-/// Work of the correct sort order.
- $config = get_config('question');
- $sortedqtypes = array();
- foreach ($QTYPES as $qtypename => $qtype) {
- $sortedqtypes[$qtypename] = $qtype->local_name();
- }
- $sortedqtypes = question_sort_qtype_array($sortedqtypes, $config);
+// Work of the correct sort order.
+$config = get_config('question');
+$sortedqtypes = array();
+foreach ($QTYPES as $qtypename => $qtype) {
+ $sortedqtypes[$qtypename] = $qtype->local_name();
+}
+$sortedqtypes = question_sort_qtype_array($sortedqtypes, $config);
-/// Process actions ============================================================
+// Process actions ============================================================
- // Disable.
- if (($disable = optional_param('disable', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
- if (!isset($QTYPES[$disable])) {
- print_error('unknownquestiontype', 'question', admin_url('qtypes.php'), $disable);
- }
-
- set_config($disable . '_disabled', 1, 'question');
- redirect(admin_url('qtypes.php'));
+// Disable.
+if (($disable = optional_param('disable', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
+ if (!isset($QTYPES[$disable])) {
+ print_error('unknownquestiontype', 'question', $thispageurl, $disable);
}
- // Enable.
- if (($enable = optional_param('enable', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
- if (!isset($QTYPES[$enable])) {
- print_error('unknownquestiontype', 'question', admin_url('qtypes.php'), $enable);
- }
+ set_config($disable . '_disabled', 1, 'question');
+ redirect($thispageurl);
+}
- if (!$QTYPES[$enable]->menu_name()) {
- print_error('cannotenable', 'question', admin_url('qtypes.php'), $enable);
- }
+// Enable.
+if (($enable = optional_param('enable', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
+ if (!isset($QTYPES[$enable])) {
+ print_error('unknownquestiontype', 'question', $thispageurl, $enable);
+ }
- unset_config($enable . '_disabled', 'question');
- redirect(admin_url('qtypes.php'));
+ if (!$QTYPES[$enable]->menu_name()) {
+ print_error('cannotenable', 'question', $thispageurl, $enable);
}
- // Move up in order.
- if (($up = optional_param('up', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
- if (!isset($QTYPES[$up])) {
- print_error('unknownquestiontype', 'question', admin_url('qtypes.php'), $up);
- }
+ unset_config($enable . '_disabled', 'question');
+ redirect($thispageurl);
+}
- $neworder = question_reorder_qtypes($sortedqtypes, $up, -1);
- question_save_qtype_order($neworder, $config);
- redirect(admin_url('qtypes.php'));
+// Move up in order.
+if (($up = optional_param('up', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
+ if (!isset($QTYPES[$up])) {
+ print_error('unknownquestiontype', 'question', $thispageurl, $up);
}
- // Move down in order.
- if (($down = optional_param('down', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
- if (!isset($QTYPES[$down])) {
- print_error('unknownquestiontype', 'question', admin_url('qtypes.php'), $down);
- }
+ $neworder = question_reorder_qtypes($sortedqtypes, $up, -1);
+ question_save_qtype_order($neworder, $config);
+ redirect($thispageurl);
+}
- $neworder = question_reorder_qtypes($sortedqtypes, $down, +1);
- question_save_qtype_order($neworder, $config);
- redirect(admin_url('qtypes.php'));
+// Move down in order.
+if (($down = optional_param('down', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
+ if (!isset($QTYPES[$down])) {
+ print_error('unknownquestiontype', 'question', $thispageurl, $down);
}
- // Delete.
- if (($delete = optional_param('delete', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
- // Check it is OK to delete this question type.
- if ($delete == 'missingtype') {
- print_error('cannotdeletemissingqtype', 'admin', admin_url('qtypes.php'));
- }
+ $neworder = question_reorder_qtypes($sortedqtypes, $down, +1);
+ question_save_qtype_order($neworder, $config);
+ redirect($thispageurl);
+}
- if (!isset($QTYPES[$delete])) {
- print_error('unknownquestiontype', 'question', admin_url('qtypes.php'), $delete);
- }
+// Delete.
+if (($delete = optional_param('delete', '', PARAM_SAFEDIR)) && confirm_sesskey()) {
+ // Check it is OK to delete this question type.
+ if ($delete == 'missingtype') {
+ print_error('cannotdeletemissingqtype', 'admin', $thispageurl);
+ }
- $qtypename = $QTYPES[$delete]->local_name();
- if ($counts[$delete]->numquestions + $counts[$delete]->numhidden > 0) {
- print_error('cannotdeleteqtypeinuse', 'admin', admin_url('qtypes.php'), $qtypename);
- }
+ if (!isset($QTYPES[$delete])) {
+ print_error('unknownquestiontype', 'question', $thispageurl, $delete);
+ }
- if ($needed[$delete] > 0) {
- print_error('cannotdeleteqtypeneeded', 'admin', admin_url('qtypes.php'), $qtypename);
- }
+ $qtypename = $QTYPES[$delete]->local_name();
+ if ($counts[$delete]->numquestions + $counts[$delete]->numhidden > 0) {
+ print_error('cannotdeleteqtypeinuse', 'admin', $thispageurl, $qtypename);
+ }
- // If not yet confirmed, display a confirmation message.
- if (!optional_param('confirm', '', PARAM_BOOL)) {
- $qtypename = $QTYPES[$delete]->local_name();
- echo $OUTPUT->header();
- echo $OUTPUT->heading(get_string('deleteqtypeareyousure', 'admin', $qtypename));
- echo $OUTPUT->confirm(get_string('deleteqtypeareyousuremessage', 'admin', $qtypename),
- admin_url('qtypes.php?delete=' . $delete . '&confirm=1'),
- admin_url('qtypes.php'));
- echo $OUTPUT->footer();
- exit;
- }
+ if ($needed[$delete] > 0) {
+ print_error('cannotdeleteqtypeneeded', 'admin', $thispageurl, $qtypename);
+ }
- // Do the deletion.
+ // If not yet confirmed, display a confirmation message.
+ if (!optional_param('confirm', '', PARAM_BOOL)) {
+ $qtypename = $QTYPES[$delete]->local_name();
echo $OUTPUT->header();
- echo $OUTPUT->heading(get_string('deletingqtype', 'admin', $qtypename));
-
- // Delete any configuration records.
- if (!unset_all_config_for_plugin('qtype_' . $delete)) {
- echo $OUTPUT->notification(get_string('errordeletingconfig', 'admin', 'qtype_' . $delete));
- }
- unset_config($delete . '_disabled', 'question');
- unset_config($delete . '_sortorder', 'question');
-
- // Then the tables themselves
- drop_plugin_tables($delete, $QTYPES[$delete]->plugin_dir() . '/db/install.xml', false);
-
- // Remove event handlers and dequeue pending events
- events_uninstall('qtype/' . $delete);
-
- $a->qtype = $qtypename;
- $a->directory = $QTYPES[$delete]->plugin_dir();
- echo $OUTPUT->box(get_string('qtypedeletefiles', 'admin', $a), 'generalbox', 'notice');
- echo $OUTPUT->continue_button(admin_url('qtypes.php'));
+ echo $OUTPUT->heading(get_string('deleteqtypeareyousure', 'admin', $qtypename));
+ echo $OUTPUT->confirm(get_string('deleteqtypeareyousuremessage', 'admin', $qtypename),
+ new moodle_url($thispageurl, array('delete' => $delete, 'confirm' => 1)),
+ $thispageurl);
echo $OUTPUT->footer();
exit;
}
- // End of process actions ==================================================
-
-/// Print the page heading.
+ // Do the deletion.
echo $OUTPUT->header();
- echo $OUTPUT->heading(get_string('manageqtypes', 'admin'));
-
-/// Set up the table.
- $table = new flexible_table('qtypeadmintable');
- $table->define_columns(array('questiontype', 'numquestions', 'version', 'requires',
- 'availableto', 'delete', 'settings'));
- $table->define_headers(array(get_string('questiontype', 'admin'), get_string('numquestions', 'admin'),
- get_string('version'), get_string('requires', 'admin'), get_string('availableq', 'question'),
- get_string('delete'), get_string('settings')));
- $table->set_attribute('id', 'qtypes');
- $table->set_attribute('class', 'generaltable generalbox boxaligncenter boxwidthwide');
- $table->setup();
-
-/// Add a row for each question type.
- $createabletypes = question_type_menu();
- foreach ($sortedqtypes as $qtypename => $localname) {
- $qtype = $QTYPES[$qtypename];
- $row = array();
-
- // Question icon and name.
- $fakequestion = new stdClass;
- $fakequestion->qtype = $qtypename;
- $icon = print_question_icon($fakequestion, true);
- $row[] = $icon . ' ' . $localname;
-
- // Number of questions of this type.
- if ($counts[$qtypename]->numquestions + $counts[$qtypename]->numhidden > 0) {
- if ($counts[$qtypename]->numhidden > 0) {
- $strcount = get_string('numquestionsandhidden', 'admin', $counts[$qtypename]);
- } else {
- $strcount = $counts[$qtypename]->numquestions;
- }
- if ($canviewreports) {
- $row[] = '<a href="' . admin_url('/report/questioninstances/index.php?qtype=' . $qtypename) .
- '" title="' . get_string('showdetails', 'admin') . '">' . $strcount . '</a>';
- } else {
- $strcount;
- }
- } else {
- $row[] = 0;
- }
+ echo $OUTPUT->heading(get_string('deletingqtype', 'admin', $qtypename));
- // Question version number.
- $version = get_config('qtype_' . $qtypename, 'version');
- if ($version) {
- $row[] = $version;
- } else {
- $row[] = '<span class="disabled">' . get_string('nodatabase', 'admin') . '</span>';
- }
+ // Delete any configuration records.
+ if (!unset_all_config_for_plugin('qtype_' . $delete)) {
+ echo $OUTPUT->notification(get_string('errordeletingconfig', 'admin', 'qtype_' . $delete));
+ }
+ unset_config($delete . '_disabled', 'question');
+ unset_config($delete . '_sortorder', 'question');
+
+ // Then the tables themselves
+ drop_plugin_tables($delete, $QTYPES[$delete]->plugin_dir() . '/db/install.xml', false);
+
+ // Remove event handlers and dequeue pending events
+ events_uninstall('qtype/' . $delete);
- // Other question types required by this one.
- $requiredtypes = $qtype->requires_qtypes();
- $strtypes = array();
- if (!empty($requiredtypes)) {
- foreach ($requiredtypes as $required) {
- $strtypes[] = $QTYPES[$required]->local_name();
- }
- $row[] = implode(', ', $strtypes);
+ $a->qtype = $qtypename;
+ $a->directory = $QTYPES[$delete]->plugin_dir();
+ echo $OUTPUT->box(get_string('qtypedeletefiles', 'admin', $a), 'generalbox', 'notice');
+ echo $OUTPUT->continue_button($thispageurl);
+ echo $OUTPUT->footer();
+ exit;
+}
+
+// End of process actions ==================================================
+
+// Print the page heading.
+echo $OUTPUT->header();
+echo $OUTPUT->heading(get_string('manageqtypes', 'admin'));
+
+// Set up the table.
+$table = new flexible_table('qtypeadmintable');
+$table->define_baseurl($thispageurl);
+$table->define_columns(array('questiontype', 'numquestions', 'version', 'requires',
+ 'availableto', 'delete', 'settings'));
+$table->define_headers(array(get_string('questiontype', 'admin'), get_string('numquestions', 'admin'),
+ get_string('version'), get_string('requires', 'admin'), get_string('availableq', 'question'),
+ get_string('delete'), get_string('settings')));
+$table->set_attribute('id', 'qtypes');
+$table->set_attribute('class', 'generaltable generalbox boxaligncenter boxwidthwide');
+$table->setup();
+
+// Add a row for each question type.
+$createabletypes = question_type_menu();
+foreach ($sortedqtypes as $qtypename => $localname) {
+ $qtype = $QTYPES[$qtypename];
+ $row = array();
+
+ // Question icon and name.
+ $fakequestion = new stdClass;
+ $fakequestion->qtype = $qtypename;
+ $icon = print_question_icon($fakequestion, true);
+ $row[] = $icon . ' ' . $localname;
+
+ // Number of questions of this type.
+ if ($counts[$qtypename]->numquestions + $counts[$qtypename]->numhidden > 0) {
+ if ($counts[$qtypename]->numhidden > 0) {
+ $strcount = get_string('numquestionsandhidden', 'admin', $counts[$qtypename]);
} else {
- $row[] = '';
+ $strcount = $counts[$qtypename]->numquestions;
}
-
- // Are people allowed to create new questions of this type?
- $rowclass = '';
- if ($qtype->menu_name()) {
- $createable = isset($createabletypes[$qtypename]);
- $icons = enable_disable_button($qtypename, $createable);
- if (!$createable) {
- $rowclass = 'dimmed_text';
- }
+ if ($canviewreports) {
+ $row[] = html_writer::link(new moodle_url('/admin/report/questioninstances/index.php',
+ array('qtype' => $qtypename)), $strcount, array('title' => get_string('showdetails', 'admin')));
} else {
- $icons = '<img src="' . $OUTPUT->pix_url('spacer') . '" alt="" class="spacer" />';
+ $strcount;
}
+ } else {
+ $row[] = 0;
+ }
- // Move icons.
- $icons .= icon_html('up', $qtypename, 't/up', get_string('up'), '');
- $icons .= icon_html('down', $qtypename, 't/down', get_string('down'), '');
- $row[] = $icons;
+ // Question version number.
+ $version = get_config('qtype_' . $qtypename, 'version');
+ if ($version) {
+ $row[] = $version;
+ } else {
+ $row[] = html_writer::tag('span', get_string('nodatabase', 'admin'), array('class' => 'disabled'));
+ }
- // Delete link, if available.
- if ($needed[$qtypename]) {
- $row[] = '';
- } else {
- $row[] = '<a href="' . admin_url('qtypes.php?delete=' . $qtypename .
- '&amp;sesskey=' . sesskey()) . '" title="' .
- get_string('uninstallqtype', 'admin') . '">' . get_string('delete') . '</a>';
+ // Other question types required by this one.
+ $requiredtypes = $qtype->requires_qtypes();
+ $strtypes = array();
+ if (!empty($requiredtypes)) {
+ foreach ($requiredtypes as $required) {
+ $strtypes[] = $QTYPES[$required]->local_name();
}
+ $row[] = implode(', ', $strtypes);
+ } else {
+ $row[] = '';
+ }
- // Settings link, if available.
- $settings = admin_get_root()->locate('qtypesetting' . $qtypename);
- if ($settings instanceof admin_externalpage) {
- $row[] = '<a href="' . $settings->url .
- '">' . get_string('settings') . '</a>';
- } else if ($settings instanceof admin_settingpage) {
- $row[] = '<a href="' . admin_url('settings.php?section=qtypesetting' . $qtypename) .
- '">' . get_string('settings') . '</a>';
- } else {
- $row[] = '';
+ // Are people allowed to create new questions of this type?
+ $rowclass = '';
+ if ($qtype->menu_name()) {
+ $createable = isset($createabletypes[$qtypename]);
+ $icons = question_types_enable_disable_icons($qtypename, $createable);
+ if (!$createable) {
+ $rowclass = 'dimmed_text';
}
-
- $table->add_data($row, $rowclass);
+ } else {
+ $icons = $OUTPUT->spacer() . ' ';
}
- $table->finish_output();
+ // Move icons.
+ $icons .= question_type_icon_html('up', $qtypename, 't/up', get_string('up'), '');
+ $icons .= question_type_icon_html('down', $qtypename, 't/down', get_string('down'), '');
+ $row[] = $icons;
- echo $OUTPUT->footer();
+ // Delete link, if available.
+ if ($needed[$qtypename]) {
+ $row[] = '';
+ } else {
+ $row[] = html_writer::link(new moodle_url($thispageurl,
+ array('delete' => $qtypename, 'sesskey' => sesskey())), get_string('delete'),
+ array('title' => get_string('uninstallqtype', 'admin')));
+ }
+
+ // Settings link, if available.
+ $settings = admin_get_root()->locate('qtypesetting' . $qtypename);
+ if ($settings instanceof admin_externalpage) {
+ $row[] = html_writer::link($settings->url, get_string('settings'));
+ } else if ($settings instanceof admin_settingpage) {
+ $row[] = html_writer::link(new moodle_url('/admin/settings.php',
+ array('section' => 'qtypesetting' . $qtypename)), get_string('settings'));
+ } else {
+ $row[] = '';
+ }
-function admin_url($endbit) {
- global $CFG;
- return $CFG->wwwroot . '/' . $CFG->admin . '/' . $endbit;
+ $table->add_data($row, $rowclass);
}
-function enable_disable_button($qtypename, $createable) {
+$table->finish_output();
+
+echo $OUTPUT->footer();
+
+function question_types_enable_disable_icons($qtypename, $createable) {
if ($createable) {
- return icon_html('disable', $qtypename, 'i/hide', get_string('enabled', 'question'), get_string('disable'));
+ return question_type_icon_html('disable', $qtypename, 'i/hide',
+ get_string('enabled', 'question'), get_string('disable'));
} else {
- return icon_html('enable', $qtypename, 'i/show', get_string('disabled', 'question'), get_string('enable'));
+ return question_type_icon_html('enable', $qtypename, 'i/show',
+ get_string('disabled', 'question'), get_string('enable'));
}
}
-function icon_html($action, $qtypename, $icon, $alt, $tip) {
+function question_type_icon_html($action, $qtypename, $icon, $alt, $tip) {
global $OUTPUT;
- if ($tip) {
- $tip = 'title="' . $tip . '" ';
- }
- $html = ' <form action="' . admin_url('qtypes.php') . '" method="post"><div>';
- $html .= '<input type="hidden" name="sesskey" value="' . sesskey() . '" />';
- $html .= '<input type="image" name="' . $action . '" value="' . $qtypename .
- '" src="' . $OUTPUT->pix_url($icon) . '" alt="' . $alt . '" ' . $tip . '/>';
- $html .= '</div></form>';
- return $html;
+ return $OUTPUT->action_icon(new moodle_url('/admin/qtypes.php',
+ array($action => $qtypename, 'sesskey' => sesskey())),
+ new pix_icon($icon, $alt, 'moodle', array('title' => '')),
+ null, array('title' => $tip)) . ' ';
}
-
Please sign in to comment.
Something went wrong with that request. Please try again.